Daniel Duvall fb3d1a083f upload-pack: allow stateless client EOF just prior to haves
During stateless packfile negotiation where a depth is given, stateless
RPC clients (e.g. git-remote-curl) will send multiple upload-pack
requests with the first containing only the
wants/shallows/deepens/filters and the subsequent containing haves/done.

When upload-pack handles such requests, entering get_common_commits
without checking whether the client has hung up can result in unexpected
EOF during the negotiation loop and a die() with message "fatal: the
remote end hung up unexpectedly".

Real world effects include:

 - A client speaking to git-http-backend via a server that doesn't check
   the exit codes of CGIs (e.g. mod_cgi) doesn't know and doesn't care
   about the fatal. It continues to process the response body as normal.

 - A client speaking to a server that does check the exit code and
   returns an errant HTTP status as a result will fail with the message
   "error: RPC failed; HTTP 500 curl 22 The requested URL returned error:
   500."

 - Admins running servers that surface the failure must workaround it by
   patching code that handles execution of git-http-backend to ignore exit
   codes or take other heuristic approaches.

 - Admins may have to deal with "hung up unexpectedly" log spam related
   to the failures even in cases where the exit code isn't surfaced as an
   HTTP server-side error status.

To avoid these EOF related fatals, have upload-pack gently peek for an
EOF between the sending of shallow/unshallow lines (followed by flush)
and the reading of client haves. If the client has hung up at this
point, exit normally.

Signed-off-by: Daniel Duvall <dan@mutual.io>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-10-30 21:18:10 -07:00
2020-10-30 13:04:24 -07:00
2020-09-22 12:36:28 -07:00
2020-08-13 11:02:15 -07:00
2020-10-05 14:01:52 -07:00
2020-03-05 10:43:02 -08:00
2020-07-30 19:18:06 -07:00
2020-08-27 14:04:49 -07:00
2019-09-28 14:04:16 +09:00
2020-09-19 15:56:06 -07:00
2020-09-19 15:56:06 -07:00
2019-11-18 15:21:28 +09:00
2019-11-18 15:21:28 +09:00
2020-04-16 15:38:06 -07:00
2020-09-02 14:39:25 -07:00
2020-09-25 15:25:38 -07:00
2020-08-11 18:04:11 -07:00
2020-08-10 10:23:57 -07:00
2020-09-30 12:53:47 -07:00
2020-08-27 14:04:49 -07:00
2019-12-01 09:04:36 -08:00
2020-08-27 14:04:49 -07:00
2020-07-06 22:09:13 -07:00
2020-08-24 14:54:31 -07:00
2020-07-30 19:18:06 -07:00
2020-10-05 14:01:51 -07:00
2020-08-27 14:04:49 -07:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2020-09-03 12:37:04 -07:00
2020-09-03 12:37:04 -07:00
2020-03-24 15:04:43 -07:00
2020-08-10 10:23:57 -07:00
2020-10-04 12:49:08 -07:00
2020-10-29 14:24:09 -07:00
2020-07-30 19:18:06 -07:00
2019-11-18 15:21:28 +09:00
2019-11-10 16:00:54 +09:00
2020-07-30 19:18:06 -07:00
2020-06-25 12:27:47 -07:00
2019-11-18 15:21:28 +09:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2020-10-27 15:09:47 -07:00
2020-05-01 13:39:55 -07:00
2019-12-01 09:04:35 -08:00
2020-08-28 14:07:09 -07:00
2020-07-30 19:18:06 -07:00
2019-12-16 13:08:39 -08:00
2020-07-06 22:09:13 -07:00
2020-07-06 22:09:13 -07:00
2020-03-24 15:04:44 -07:00
2020-03-24 15:04:44 -07:00
2020-07-30 19:18:06 -07:00
2020-09-22 12:36:28 -07:00
2020-10-27 15:09:50 -07:00
2020-10-27 15:09:50 -07:00
2020-10-29 14:24:09 -07:00
2020-10-27 15:09:49 -07:00
2020-10-27 15:09:49 -07:00
2019-11-10 16:00:54 +09:00
2020-04-29 16:15:27 -07:00
2020-09-30 12:53:47 -07:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2020-08-11 18:04:11 -07:00
2020-08-13 14:13:39 -07:00
2020-09-02 14:39:25 -07:00
2019-11-13 10:09:10 +09:00
2019-11-18 15:21:29 +09:00
2020-07-30 19:18:06 -07:00
2020-07-30 19:18:06 -07:00
2019-09-05 14:10:18 -07:00
2020-07-30 19:18:06 -07:00
2020-07-28 15:02:17 -07:00
2019-11-10 16:00:54 +09:00
2020-10-05 14:01:52 -07:00
2020-10-05 14:01:52 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%