Johannes Schindelin b01b9b81d3 credential: disallow Carriage Returns in the protocol by default
While Git has documented that the credential protocol is line-based,
with newlines as terminators, the exact shape of a newline has not been
documented.

From Git's perspective, which is firmly rooted in the Linux ecosystem,
it is clear that "a newline" means a Line Feed character.

However, even Git's credential protocol respects Windows line endings
(a Carriage Return character followed by a Line Feed character, "CR/LF")
by virtue of using `strbuf_getline()`.

There is a third category of line endings that has been used originally
by MacOS, and that is respected by the default line readers of .NET and
node.js: bare Carriage Returns.

Git cannot handle those, and what is worse: Git's remedy against
CVE-2020-5260 does not catch when credential helpers are used that
interpret bare Carriage Returns as newlines.

Git Credential Manager addressed this as CVE-2024-50338, but other
credential helpers may still be vulnerable. So let's not only disallow
Line Feed characters as part of the values in the credential protocol,
but also disallow Carriage Return characters.

In the unlikely event that a credential helper relies on Carriage
Returns in the protocol, introduce an escape hatch via the
`credential.protectProtocol` config setting.

This addresses CVE-2024-52006.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
2024-11-26 20:24:04 +01:00
2022-10-07 17:19:59 -07:00
2022-07-10 14:43:34 -07:00
2023-04-17 21:16:10 +02:00
2023-02-27 10:08:57 -08:00
2023-02-18 09:29:13 -08:00
2023-01-23 13:39:51 -08:00
2022-08-03 13:36:09 -07:00
2023-02-15 17:11:52 -08:00
2023-02-22 14:55:45 -08:00
2022-10-30 21:04:44 -04:00
2023-01-09 13:28:36 +09:00
2023-01-09 13:28:36 +09:00
2023-01-02 21:37:18 +09:00
2022-07-19 12:45:31 -07:00
2023-02-27 10:08:56 -08:00
2023-02-27 10:08:56 -08:00
2024-04-19 12:38:37 +02:00
2024-04-19 12:38:37 +02:00
2024-04-19 12:38:37 +02:00
2022-03-28 10:25:52 -07:00
2023-04-17 21:16:08 +02:00
2023-04-17 21:15:56 +02:00
2024-05-30 16:57:31 -07:00
2023-02-24 11:32:29 -08:00
2023-02-22 14:55:45 -08:00
2023-04-17 21:15:49 +02:00
2023-04-17 21:15:44 +02:00
2022-04-06 15:21:59 -07:00
2024-04-19 12:38:37 +02:00
2022-05-02 09:50:37 -07:00
2022-09-14 12:56:39 -07:00
2022-09-14 12:56:39 -07:00
2022-12-15 09:09:38 +09:00
2023-01-09 13:28:36 +09:00
2022-10-30 21:04:41 -04:00
2022-08-29 14:55:11 -07:00
2022-08-22 15:08:30 -07:00
2022-12-13 21:23:36 +09:00
2023-04-17 21:15:49 +02:00
2024-04-19 12:38:37 +02:00
2024-05-30 16:57:31 -07:00
2022-12-01 18:38:07 +09:00
2022-10-30 14:04:51 -04:00
2024-04-19 12:38:37 +02:00
2024-04-19 12:38:37 +02:00
2022-08-30 14:16:49 -07:00
2022-10-24 12:45:26 -07:00
2022-10-24 12:45:26 -07:00
2023-01-02 21:37:18 +09:00
2022-12-13 21:09:40 +09:00
2022-12-13 21:09:40 +09:00
2022-05-02 09:50:37 -07:00
2023-01-23 13:39:51 -08:00
2022-12-26 11:42:05 +09:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org (not the Git list). The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%