Derrick Stolee a481d4378c sparse-checkout: fix segfault on malformed patterns
Then core.sparseCheckoutCone is enabled, the sparse-checkout patterns are
used to populate two hashsets that accelerate pattern matching. If the user
modifies the sparse-checkout file outside of the 'sparse-checkout' builtin,
then strange patterns can happen, triggering some error checks.

One of these error checks is possible to hit when some special characters
exist in a line. A warning message is correctly written to stderr, but then
there is additional logic that attempts to remove the line from the hashset
and free the data. This leads to a segfault in the 'git sparse-checkout
list' command because it iterates over the contents of the hashset, which is
now invalid.

The fix here is to stop trying to remove from the hashset. In addition,
we disable cone mode sparse-checkout because of the malformed data. This
results in the pattern-matching working with a possibly-slower
algorithm, but using the patterns as they are in the sparse-checkout
file.

This also changes the behavior of commands such as 'git sparse-checkout
list' because the output patterns will be the contents of the
sparse-checkout file instead of the list of directories. This is an
existing behavior for other types of bad patterns.

Add a test that triggers the segfault without the code change.

Reported-by: John Burnett <johnburnett@johnburnett.com>
Reviewed-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2021-12-30 14:39:57 -08:00
2021-12-10 14:35:15 -08:00
2021-12-10 14:35:16 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-07-22 13:05:54 -07:00
2021-11-14 15:19:23 +01:00
2021-07-13 16:52:50 -07:00
2021-08-12 14:00:52 -07:00
2021-03-08 09:56:34 -08:00
2021-01-21 15:50:00 -08:00
2021-03-13 16:00:09 -08:00
2021-04-27 16:31:39 +09:00
2021-05-07 12:47:41 +09:00
2021-12-10 14:35:12 -08:00
2021-01-23 17:14:07 -08:00
2021-12-10 14:35:12 -08:00
2021-07-13 16:52:50 -07:00
2021-03-13 16:00:09 -08:00
2021-10-25 16:07:00 -07:00
2021-11-04 12:38:09 -07:00
2021-03-13 16:00:09 -08:00
2021-10-11 10:21:47 -07:00
2021-10-25 16:06:58 -07:00
2021-09-23 13:44:48 -07:00
2021-11-24 10:55:13 -08:00
2021-10-18 15:47:56 -07:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-10-25 16:06:58 -07:00
2021-10-11 10:21:47 -07:00
2021-12-10 14:35:14 -08:00
2021-10-28 15:32:14 -07:00
2021-03-13 16:00:09 -08:00
2021-04-27 16:31:39 +09:00
2021-12-10 14:35:10 -08:00
2021-03-13 16:00:09 -08:00
2021-03-13 16:00:09 -08:00
2021-09-20 15:20:40 -07:00
2021-03-13 16:00:09 -08:00
2021-08-24 15:32:37 -07:00
2021-12-10 14:35:12 -08:00
2021-11-24 10:55:13 -08:00
2021-10-25 16:06:58 -07:00
2021-12-10 14:35:16 -08:00
2021-05-04 12:09:43 +09:00
2021-12-10 14:35:12 -08:00
2021-09-20 15:20:43 -07:00
2021-05-04 11:52:02 +09:00
2021-05-04 11:52:02 +09:00
2021-10-29 14:59:29 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%