Elijah Newren a3ec9eaf38 sequencer: fix --allow-empty-message behavior, make it smarter
In commit b00bf1c9a8 ("git-rebase: make --allow-empty-message the
default", 2018-06-27), several arguments were given for transplanting
empty commits without halting and asking the user for confirmation on
each commit.  These arguments were incomplete because the logic clearly
assumed the only cases under consideration were transplanting of commits
with empty messages (see the comment about "There are two sources for
commits with empty messages).  It didn't discuss or even consider
rewords, squashes, etc. where the user is explicitly asked for a new
commit message and provides an empty one.  (My bad, I totally should
have thought about that at the time, but just didn't.)

Rewords and squashes are significantly different, though, as described
by SZEDER:

    Let's suppose you start an interactive rebase, choose a commit to
    squash, save the instruction sheet, rebase fires up your editor, and
    then you notice that you mistakenly chose the wrong commit to
    squash.  What do you do, how do you abort?

    Before [that commit] you could clear the commit message, exit the
    editor, and then rebase would say "Aborting commit due to empty
    commit message.", and you get to run 'git rebase --abort', and start
    over.

    But [since that commit, ...] saving the commit message as is would
    let rebase continue and create a bunch of unnecessary objects, and
    then you would have to use the reflog to return to the pre-rebase
    state.

Also, he states:

    The instructions in the commit message template, which is shown for
    'reword' and 'squash', too, still say...

    # Please enter the commit message for your changes. Lines starting
    # with '#' will be ignored, and an empty message aborts the commit.

These are sound arguments that when editing commit messages during a
sequencer operation, that if the commit message is empty then the
operation should halt and ask the user to correct.  The arguments in
commit b00bf1c9a8 (referenced above) still apply when transplanting
previously created commits with empty commit messages, so the sequencer
should not halt for those.

Furthermore, all rationale so far applies equally for cherry-pick as for
rebase.  Therefore, make the code default to --allow-empty-message when
transplanting an existing commit, and to default to halting when the
user is asked to edit a commit message and provides an empty one -- for
both rebase and cherry-pick.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2018-09-13 13:25:08 -07:00
2018-06-18 10:18:45 -07:00
2018-05-30 14:04:08 +09:00
2018-06-19 02:19:42 +09:00
2018-05-30 14:04:07 +09:00
2018-06-01 15:06:37 +09:00
2018-05-23 14:38:17 +09:00
2018-05-30 14:04:07 +09:00
2018-05-30 14:04:07 +09:00
2018-05-30 14:04:07 +09:00
2017-12-27 11:16:25 -08:00
2018-05-08 15:59:20 +09:00
2018-05-30 14:04:07 +09:00
2018-05-30 14:04:05 +09:00
2018-05-02 13:59:52 +09:00
2018-06-01 15:06:37 +09:00
2018-03-30 12:49:57 -07:00
2018-03-30 12:49:57 -07:00
2018-05-30 14:04:07 +09:00
2018-06-13 12:50:46 -07:00
2018-05-30 14:04:08 +09:00
2018-05-08 15:59:17 +09:00
2018-05-08 15:59:27 +09:00
2018-06-01 15:06:37 +09:00
2018-03-15 12:01:09 -07:00
2018-02-13 13:39:04 -08:00
2018-05-08 15:59:22 +09:00
2018-05-08 15:59:22 +09:00
2018-05-30 14:04:10 +09:00
2018-02-15 14:55:43 -08:00
2018-06-18 11:23:22 -07:00
2018-05-30 14:04:10 +09:00
2018-03-14 09:23:50 -07:00
2018-05-08 15:59:34 +09:00
2018-05-08 15:59:17 +09:00
2018-05-08 15:59:16 +09:00
2018-05-21 23:55:12 -04:00
2018-05-08 15:59:34 +09:00
2018-06-18 10:18:41 -07:00
2018-06-21 10:00:06 -07:00
2018-06-01 15:06:37 +09:00
2018-06-01 15:06:37 +09:00
2018-05-08 15:59:16 +09:00
2018-04-11 13:09:55 +09:00
2018-05-30 21:51:28 +09:00
2018-05-23 14:38:13 +09:00
2018-06-18 11:23:24 -07:00
2018-05-30 14:04:07 +09:00
2018-05-23 14:38:16 +09:00
2017-12-27 12:28:06 -08:00
2018-05-30 14:04:07 +09:00
2018-02-02 11:28:41 -08:00
2018-05-30 14:04:10 +09:00
2018-06-01 15:06:37 +09:00
2018-05-29 17:10:05 +09:00
2018-05-30 14:04:07 +09:00
2018-05-23 14:38:13 +09:00
2017-12-19 11:33:55 -08:00
2018-01-16 12:16:54 -08:00
2018-05-30 14:04:10 +09:00
2018-05-30 14:04:07 +09:00
2018-05-30 21:51:28 +09:00
2018-05-08 15:59:21 +09:00
2018-06-04 21:39:50 +09:00
2018-05-22 14:28:26 +09:00
2018-05-30 14:04:05 +09:00
2018-05-30 14:04:10 +09:00
2018-03-15 12:01:08 -07:00
2018-05-30 14:04:11 +09:00
2018-05-30 14:04:07 +09:00
2018-06-01 15:06:37 +09:00
2018-04-24 11:12:32 +09:00
2018-05-30 14:04:07 +09:00
2018-05-30 14:04:10 +09:00
2018-05-30 14:04:10 +09:00
2018-03-30 12:49:57 -07:00
2018-03-30 12:49:57 -07:00
2018-05-23 14:38:13 +09:00
2018-05-30 21:51:28 +09:00
2018-05-29 17:10:05 +09:00
2018-05-29 17:10:05 +09:00
2018-05-23 14:38:13 +09:00
2018-05-30 14:04:10 +09:00

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%