Jeff King a04bc71725 revision: retain argv NULL invariant in setup_revisions()
In an argc/argv pair, the entry for argv[argc] is generally NULL. You
can iterate by counting up to argc, or by looking for the NULL entry in
argv.

When we pass such a pair to setup_revisions(), it shrinks argc to
account for the options we consumed and returns the result to the
caller. But it doesn't touch the entries after the reduced argc. So
argv[argc] will be left pointing at some arbitrary entry rather than
NULL.

This isn't the source of any known bugs, since all callers are aware of
the limitation and act accordingly. But it's a possible gotcha that may
be easy to miss.

Let's set the new argv[argc] to NULL, taking care to free it if the
caller asked us to do so.

It is tempting to do likewise for all of the entries afterwards, too, as
some of them may also need to be freed (e.g., if coming from a strvec).
But doing so isn't entirely trivial, as we munge argc in the function
(e.g., when we find "--" and move all of the entries after it into the
prune_data list). It would be possible with some light refactoring, but
it's probably not worth it. Nobody should ever look at them (they are
beyond the revised argc and past the NULL argv entry) outside of strvec
cleanup, and setup_revisions_from_strvec() already handles this case.

There's one other interesting gotcha: many callers which do not want to
provide arguments just pass 0/NULL for argc/argv. We need to check for
this case before assigning the final NULL.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-09-22 14:27:03 -07:00
2025-08-04 08:10:34 -07:00
2025-08-07 08:48:57 -07:00
2025-05-15 13:46:47 -07:00
2025-07-01 07:46:22 -07:00
2024-09-06 09:31:15 -07:00
2025-07-01 14:46:38 -07:00
2025-03-26 16:26:09 +09:00
2025-07-15 15:18:18 -07:00
2025-07-16 22:16:15 -07:00
2024-09-16 10:46:00 -07:00
2025-08-04 08:10:33 -07:00
2025-07-23 08:15:18 -07:00
2025-01-21 08:44:54 -08:00
2025-01-21 08:44:54 -08:00
2024-12-18 10:44:31 -08:00
2025-07-01 14:46:37 -07:00
2025-03-03 13:49:23 -08:00
2025-07-01 14:46:38 -07:00
2025-07-23 08:15:18 -07:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2024-09-19 13:46:00 -07:00
2025-08-17 17:18:23 -07:00
2025-07-25 16:34:13 -07:00
2024-12-18 10:44:31 -08:00
2025-07-01 14:46:38 -07:00
2025-05-08 12:36:31 -07:00
2025-07-01 14:46:38 -07:00
2025-01-31 10:06:10 -08:00
2025-06-24 09:48:51 -07:00
2024-10-23 16:16:36 -04:00
2025-07-01 14:46:38 -07:00
2025-07-01 14:46:37 -07:00
2025-07-23 08:15:18 -07:00
2024-12-18 10:44:31 -08:00
2025-07-01 14:46:38 -07:00
2025-07-23 08:15:18 -07:00
2025-07-01 14:46:38 -07:00
2025-04-23 13:58:50 -07:00
2025-05-12 13:06:26 -07:00
2024-10-21 16:05:04 -04:00
2025-07-15 15:18:18 -07:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-07-01 14:58:24 -07:00
2025-07-23 08:15:18 -07:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-07-01 14:46:37 -07:00
2025-03-03 13:49:19 -08:00
2024-09-19 13:46:01 -07:00
2025-08-03 18:44:26 -07:00
2025-06-17 10:44:42 -07:00
2025-06-17 10:44:38 -07:00
2025-06-17 10:44:38 -07:00
2025-07-15 15:18:18 -07:00
2025-07-15 15:18:18 -07:00
2024-09-19 13:46:12 -07:00
2025-07-15 15:18:18 -07:00
2025-07-01 14:58:24 -07:00
2024-12-18 10:44:30 -08:00
2025-07-23 08:15:21 -07:00
2024-09-30 11:23:03 -07:00
2025-07-01 14:46:37 -07:00
2024-12-23 09:32:11 -08:00
2025-07-01 14:46:38 -07:00
2025-03-03 13:49:26 -08:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-07-23 08:15:18 -07:00
2025-05-15 13:46:47 -07:00
2025-03-03 13:49:27 -08:00
2025-07-01 14:46:38 -07:00
2025-02-06 14:56:45 -08:00
2025-06-25 14:07:36 -07:00
2025-05-15 17:24:55 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%