Jeff King 92fb0db94c pack-objects: add checks for duplicate objects
Additional checks are added in have_duplicate_entry() and
obj_is_packed() to avoid duplicate objects in the reuse
bitmap. It was probably buggy to not have such a check
before.

Git as a client would never both asks for a tag by sha1 and
specify "include-tag", but libgit2 will, so a libgit2 client
cloning from a Git server would trigger the bug.

If a client both asks for a tag by sha1 and specifies
"include-tag", we may end up including the tag in the reuse
bitmap (due to the first thing), and then later adding it to
the packlist (due to the second). This results in duplicate
objects in the pack, which git chokes on. We should notice
that we are already including it when doing the include-tag
portion, and avoid adding it to the packlist.

The simplest place to fix this is right in add_ref_tag(),
where we could avoid peeling the tag at all if we know that
we are already including it. However, this pushes the check
instead into have_duplicate_entry(). This fixes not only
this case, but also means that we cannot have any similar
problems lurking in other code.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2020-01-23 10:51:50 -08:00
2019-07-29 12:39:13 -07:00
2019-08-02 13:12:02 -07:00
2019-08-02 13:12:02 -07:00
2019-04-01 11:57:39 +09:00
2019-04-01 11:57:39 +09:00
2019-05-14 16:45:01 +09:00
2019-05-30 10:50:45 -07:00
2019-08-02 13:12:02 -07:00
2019-07-19 11:30:21 -07:00
2019-07-19 11:30:20 -07:00
2019-07-09 15:25:44 -07:00
2019-07-09 15:25:44 -07:00
2019-07-25 13:59:20 -07:00
2019-07-09 15:25:43 -07:00
2019-05-05 15:20:10 +09:00
2019-07-09 15:25:43 -07:00
2019-05-13 23:50:32 +09:00
2019-07-19 11:30:20 -07:00
2019-07-25 13:59:20 -07:00
2019-08-16 10:28:23 -07:00
2019-08-02 13:12:02 -07:00
2019-06-13 13:19:42 -07:00
2019-05-05 15:20:10 +09:00
2019-04-22 11:14:43 +09:00
2019-08-02 13:12:02 -07:00
2019-06-11 10:34:40 -07:00
2019-07-09 15:25:43 -07:00
2019-07-19 11:30:19 -07:00
2019-07-19 11:30:20 -07:00
2019-07-19 11:30:20 -07:00
2019-05-05 15:20:10 +09:00
2019-09-13 14:40:33 -07:00
2019-09-13 14:40:33 -07:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2019-06-17 18:15:04 -07:00
2019-02-05 14:26:09 -08:00
2019-07-11 15:16:49 -07:00
2019-05-05 15:20:10 +09:00
2019-04-01 11:57:39 +09:00
2019-05-05 15:20:10 +09:00
2019-02-05 14:26:11 -08:00
2019-05-05 15:20:10 +09:00
2019-05-13 23:50:35 +09:00
2019-05-05 15:20:10 +09:00
2019-06-21 11:24:08 -07:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%