Thomas Gummerer 63b50c8ffe stash: fix show referencing stash index
In the conversion of 'stash show' to C in dc7bd382b1 ("stash: convert
show to builtin", 2019-02-25), 'git stash show <n>', where n is the
index of a stash got broken, if n is not a file or a valid revision by
itself.

'stash show' accepts any flag 'git diff' accepts for changing the
output format.  Internally we use 'setup_revisions()' to parse these
command line flags.  Currently we pass the whole argv through to
'setup_revisions()', which includes the stash index.

As the stash index is not a valid revision or a file in the working
tree in most cases however, this 'setup_revisions()' call (and thus
the whole command) ends up failing if we use this form of 'git stash
show'.

Instead of passing the whole argv to 'setup_revisions()', only pass
the flags (and the command name) through, while excluding the stash
reference.  The stash reference is parsed (and validated) in
'get_stash_info()' already.

This separate parsing also means that we currently do produce the
correct output if the command succeeds.

Reported-by: Mike Hommey <mh@glandium.org>
Signed-off-by: Thomas Gummerer <t.gummerer@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-06-19 14:47:49 -07:00
2019-05-19 16:45:31 +09:00
2019-06-03 11:25:12 -07:00
2019-04-01 11:57:39 +09:00
2019-04-01 11:57:39 +09:00
2019-04-16 19:28:11 +09:00
2019-05-14 16:45:01 +09:00
2019-06-19 14:47:49 -07:00
2019-05-30 10:50:45 -07:00
2019-04-12 13:34:17 +09:00
2019-05-09 00:37:27 +09:00
2019-04-12 10:52:35 +09:00
2018-08-20 12:41:32 -07:00
2018-09-12 15:15:34 -07:00
2019-01-02 10:19:05 -08:00
2019-05-09 00:37:25 +09:00
2019-05-13 23:50:31 +09:00
2018-08-20 12:41:32 -07:00
2019-05-05 15:20:10 +09:00
2019-05-30 10:50:44 -07:00
2018-10-19 13:34:02 +09:00
2018-10-19 13:34:02 +09:00
2019-05-13 23:50:32 +09:00
2019-03-07 09:59:51 +09:00
2019-06-07 09:39:21 -07:00
2019-05-09 00:37:27 +09:00
2019-05-05 15:20:10 +09:00
2019-04-22 11:14:43 +09:00
2018-08-29 13:05:35 -07:00
2019-05-19 16:45:28 +09:00
2019-01-14 12:13:04 -08:00
2019-05-07 13:48:41 +09:00
2019-02-07 13:02:28 -08:00
2018-10-04 11:12:14 -07:00
2019-04-01 11:57:37 +09:00
2019-05-05 15:20:10 +09:00
2018-10-19 13:34:02 +09:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2019-02-05 14:26:09 -08:00
2018-11-02 12:14:21 +09:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2018-08-15 15:08:23 -07:00
2019-04-01 11:57:39 +09:00
2019-03-07 11:59:54 +09:00
2019-01-14 12:13:04 -08:00
2019-05-05 15:20:10 +09:00
2018-06-01 15:06:37 +09:00
2019-02-05 14:26:11 -08:00
2019-04-22 11:14:43 +09:00
2019-04-22 11:14:43 +09:00
2018-12-09 12:37:32 +09:00
2019-05-05 15:20:10 +09:00
2019-05-13 23:50:35 +09:00
2019-05-05 15:20:10 +09:00
2019-02-06 22:05:23 -08:00
2018-10-19 13:34:02 +09:00

Build Status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission). To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org. The mailing list archives are available at https://public-inbox.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%