Phillip Wood 5b44c3bd57 rebase -i: respect commit.cleanup when picking fixups
If the user uses a prepare-commit-msg hook to add comments to the
commit message template and sets commit.cleanup to remove them when the
commit is created then the comments will not be removed when rebase
commits the final command in a chain of "fixup" commands[1].  This
happens because f7d42ceec5 (rebase -i: do leave commit message intact
in fixup! chains, 2021-01-28) started passing the VERBATIM_MSG flag
when committing the final command in a chain of "fixup" commands. That
change was added in response to a bug report[2] where the commit
message was being cleaned up when it should not be. The cause of that
bug was that before f7d42ceec5 the sequencer passed CLEANUP_MSG
when committing the final fixup. That commit should have simply
removed the CLEANUP_MSG flag, not changed it to VERBATIM_MSG. Using
VERBATIM_MSG ignores the user's commit.cleanup config when committing
the final fixup which means it behaves differently to an ordinary
"pick" command which respects commit.cleanup.

Fix this by not setting an explicit cleanup flag when committing the
final fixup which matches the way "pick" commands behave. The test
added in f7d42ceec5 is replaced with one that checks that "fixup"
and "pick" commands do not clean up the message when commit.cleanup
is not set and do clean up the message when it is set.

[1] https://lore.kernel.org/git/CA+itcS3DxbgpFy2aPRvHQvTAYE=dU0kfeDdidVwWLU=rBAWR4w@mail.gmail.com
[2] https://lore.kernel.org/git/CANVGpwZGbzYLMeMze64e_OU9p3bjyEgzC5thmNBr6LttBt+YGw@mail.gmail.com

Reported-by: Simon Cheng <cyqsimon@gmail.com>
Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-09-18 08:30:44 -07:00
2025-06-03 08:55:24 -07:00
2025-06-15 21:54:23 -07:00
2025-06-15 21:54:23 -07:00
2025-06-15 21:54:23 -07:00
2025-05-27 13:59:09 -07:00
2025-05-15 13:46:47 -07:00
2024-12-18 10:44:30 -08:00
2025-03-26 16:26:09 +09:00
2025-06-15 21:54:23 -07:00
2025-04-24 17:25:33 -07:00
2025-05-27 13:59:11 -07:00
2025-04-24 17:25:33 -07:00
2025-06-15 21:54:23 -07:00
2025-03-05 10:37:44 -08:00
2025-01-21 08:44:54 -08:00
2025-01-21 08:44:54 -08:00
2024-12-23 09:32:11 -08:00
2024-12-18 10:44:31 -08:00
2025-03-03 13:49:23 -08:00
2025-05-05 14:56:24 -07:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2024-10-23 16:16:36 -04:00
2025-06-15 21:57:08 -07:00
2025-03-03 08:17:47 -08:00
2024-12-18 10:44:31 -08:00
2025-05-08 12:36:31 -07:00
2025-05-15 13:46:47 -07:00
2025-06-06 08:12:24 -07:00
2025-01-31 10:06:10 -08:00
2024-10-23 16:16:36 -04:00
2024-12-18 10:44:31 -08:00
2025-05-22 14:48:37 -07:00
2025-04-24 17:25:33 -07:00
2025-04-23 13:58:50 -07:00
2025-05-12 13:06:26 -07:00
2024-10-21 16:05:04 -04:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-02-03 16:12:42 -08:00
2025-02-03 16:12:42 -08:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-03-03 13:49:19 -08:00
2025-06-15 21:57:08 -07:00
2024-12-18 10:44:30 -08:00
2024-12-27 08:12:40 -08:00
2024-09-30 11:23:03 -07:00
2025-01-13 12:55:26 -08:00
2025-01-13 12:55:26 -08:00
2024-12-23 09:32:11 -08:00
2025-03-03 13:49:26 -08:00
2024-12-18 10:44:30 -08:00
2024-12-18 10:44:30 -08:00
2025-05-15 13:46:47 -07:00
2025-03-03 13:49:27 -08:00
2025-02-06 14:56:45 -08:00
2025-01-17 13:30:02 -08:00
2025-05-15 17:24:55 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.adoc to get started, then see Documentation/giteveryday.adoc for a useful minimum set of commands, and Documentation/git-<commandname>.adoc for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.adoc (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email to git+subscribe@vger.kernel.org (see https://subspace.kernel.org/subscribing.html for details). The mailing list archives are available at https://lore.kernel.org/git/, https://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%