Derrick Stolee 0af067276e builtin/repack.c: only repack .packs that exist
In 73320e49ad (builtin/repack.c: only collect fully-formed packs,
2023-06-07), we switched the check for which packs to collect by
starting at the .idx files and looking for matching .pack files. This
avoids trying to repack pack-files that have not had their pack-indexes
installed yet.

However, it does cause maintenance to halt if we find the (problematic,
but not insurmountable) case of a .idx file without a corresponding
.pack file. In an environment where packfile maintenance is a critical
function, such a hard stop is costly and requires human intervention to
resolve (by deleting the .idx file).

This was not the case before. We successfully repacked through this
scenario until the recent change to scan for .idx files.

Further, if we are actually in a case where objects are missing, we
detect this at a different point during the reachability walk.

In other cases, Git prepares its list of packfiles by scanning .idx
files and then only adds it to the packfile list if the corresponding
.pack file exists. It even does so without a warning! (See
add_packed_git() in packfile.c for details.)

This case is much less likely to occur than the failures seen before
73320e49ad. Packfiles are "installed" by writing the .pack file before
the .idx and that process can be interrupted. Packfiles _should_ be
deleted by deleting the .idx first, followed by the .pack file, but
unlink_pack_path() does not do this: it deletes the .pack _first_,
allowing a window where this process could be interrupted. We leave the
consideration of changing this order as a separate concern. Knowing that
this condition is possible from interrupted Git processes and not other
tools lends some weight that Git should be more flexible around this
scenario.

Add a check to see if the .pack file exists before adding it to the list
for repacking. This will stop a number of maintenance failures seen in
production but fixed by deleting the .idx files.

This brings us closer to the case before 73320e49ad in that 'git
repack' will not fail when there is an orphaned .idx file, at least, not
due to the way we scan for packfiles. In the case that the .pack file
was erroneously deleted without copies of its objects in other installed
packfiles, then 'git repack' will fail due to the reachable object walk.

This does resolve the case where automated repacks will no longer be
halted on this case. The tests in t7700 show both these successful
scenarios and the case of failing if the .pack was truly required.

Signed-off-by: Derrick Stolee <derrickstolee@github.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2023-07-11 13:07:50 -07:00
2023-06-03 10:35:13 +09:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-07-08 11:23:08 -07:00
2023-06-01 00:53:09 +08:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:46 -07:00
2023-06-28 14:06:39 -07:00
2023-07-06 11:54:47 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-07-04 16:08:18 -07:00
2023-04-24 12:47:33 -07:00
2023-07-06 11:54:48 -07:00
2023-04-24 12:47:33 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-04-10 08:46:40 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:46 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-06-28 14:06:39 -07:00
2023-04-24 22:31:32 -07:00
2023-04-17 21:15:56 +02:00
2023-06-13 12:29:46 -07:00
2023-07-06 11:54:48 -07:00
2023-06-28 14:06:39 -07:00
2023-06-28 14:06:40 -07:00
2023-07-06 11:54:48 -07:00
2023-04-17 21:15:44 +02:00
2023-06-28 14:06:39 -07:00
2023-06-28 14:06:39 -07:00
2023-04-17 21:15:49 +02:00
2023-06-28 14:06:39 -07:00
2023-06-28 14:06:39 -07:00
2023-06-21 13:39:54 -07:00
2023-07-06 11:54:48 -07:00
2023-06-21 13:39:54 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:46 -07:00
2023-06-28 14:06:39 -07:00
2023-07-06 11:54:46 -07:00
2023-06-12 13:49:36 -07:00
2023-07-06 11:54:48 -07:00
2023-06-13 12:29:46 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2023-06-28 14:06:39 -07:00
2023-07-06 11:54:48 -07:00
2023-07-06 11:54:48 -07:00
2022-12-01 18:38:07 +09:00
2023-07-06 11:54:46 -07:00
2023-07-06 11:54:46 -07:00
2023-06-28 14:06:39 -07:00
2023-06-28 14:06:39 -07:00
2023-03-17 14:03:09 -07:00
2023-06-28 14:06:39 -07:00
2023-07-06 11:54:48 -07:00
2023-06-28 14:06:39 -07:00
2023-06-28 14:06:39 -07:00
2022-12-13 21:09:40 +09:00
2022-12-13 21:09:40 +09:00
2023-04-04 14:28:27 -07:00
2023-07-06 11:54:48 -07:00
2023-05-17 10:11:41 -07:00

Build status

Git - fast, scalable, distributed revision control system

Git is a fast, scalable, distributed revision control system with an unusually rich command set that provides both high-level operations and full access to internals.

Git is an Open Source project covered by the GNU General Public License version 2 (some parts of it are under different licenses, compatible with the GPLv2). It was originally written by Linus Torvalds with help of a group of hackers around the net.

Please read the file INSTALL for installation instructions.

Many Git online resources are accessible from https://git-scm.com/ including full documentation and Git related tools.

See Documentation/gittutorial.txt to get started, then see Documentation/giteveryday.txt for a useful minimum set of commands, and Documentation/git-<commandname>.txt for documentation of each command. If git has been correctly installed, then the tutorial can also be read with man gittutorial or git help tutorial, and the documentation of each command with man git-<commandname> or git help <commandname>.

CVS users may also want to read Documentation/gitcvs-migration.txt (man gitcvs-migration or git help cvs-migration if git is installed).

The user discussion and development of Git take place on the Git mailing list -- everyone is welcome to post bug reports, feature requests, comments and patches to git@vger.kernel.org (read Documentation/SubmittingPatches for instructions on patch submission and Documentation/CodingGuidelines).

Those wishing to help with error message, usage and informational message string translations (localization l10) should see po/README.md (a po file is a Portable Object file that holds the translations).

To subscribe to the list, send an email with just "subscribe git" in the body to majordomo@vger.kernel.org (not the Git list). The mailing list archives are available at https://lore.kernel.org/git/, http://marc.info/?l=git and other archival sites.

Issues which are security relevant should be disclosed privately to the Git Security mailing list git-security@googlegroups.com.

The maintainer frequently sends the "What's cooking" reports that list the current status of various development topics to the mailing list. The discussion following them give a good reference for project status, development direction and remaining tasks.

The name "git" was given by Linus Torvalds when he wrote the very first version. He described the tool as "the stupid content tracker" and the name as (depending on your mood):

  • random three-letter combination that is pronounceable, and not actually used by any common UNIX command. The fact that it is a mispronunciation of "get" may or may not be relevant.
  • stupid. contemptible and despicable. simple. Take your pick from the dictionary of slang.
  • "global information tracker": you're in a good mood, and it actually works for you. Angels sing, and a light suddenly fills the room.
  • "goddamn idiotic truckload of sh*t": when it breaks
Description
No description provided
Readme 279 MiB
Languages
C 50.5%
Shell 38.7%
Perl 4.5%
Tcl 3.2%
Python 0.8%
Other 2.1%