f1bee82873
Change tweak_untracked_cache() in "read-cache.c" to use a switch() to have the compiler assert that we checked all possible values in the "enum untracked_cache_setting" type, and likewise remove the "default" case in fetch_negotiator_init() in favor of checking for "FETCH_NEGOTIATION_UNSET" and "FETCH_NEGOTIATION_NONE". As will be discussed in a subsequent we'll only ever have either of these set to FETCH_NEGOTIATION_NONE, FETCH_NEGOTIATION_UNSET and UNTRACKED_CACHE_UNSET within the prepare_repo_settings() function itself. In preparation for fixing that code let's add a BUG() here to mark this as unreachable code. Seead0fb65999(repo-settings: parse core.untrackedCache, 2019-08-13) for when the "unset" and "keep" handling for core.untrackedCache was consolidated, andaaf633c2ad(repo-settings: create feature.experimental setting, 2019-08-13) for the addition of the "default" pattern in "fetch-negotiator.c". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
29 lines
742 B
C
29 lines
742 B
C
#include "git-compat-util.h"
|
|
#include "fetch-negotiator.h"
|
|
#include "negotiator/default.h"
|
|
#include "negotiator/skipping.h"
|
|
#include "negotiator/noop.h"
|
|
#include "repository.h"
|
|
|
|
void fetch_negotiator_init(struct repository *r,
|
|
struct fetch_negotiator *negotiator)
|
|
{
|
|
prepare_repo_settings(r);
|
|
switch(r->settings.fetch_negotiation_algorithm) {
|
|
case FETCH_NEGOTIATION_SKIPPING:
|
|
skipping_negotiator_init(negotiator);
|
|
return;
|
|
|
|
case FETCH_NEGOTIATION_NOOP:
|
|
noop_negotiator_init(negotiator);
|
|
return;
|
|
|
|
case FETCH_NEGOTIATION_DEFAULT:
|
|
default_negotiator_init(negotiator);
|
|
return;
|
|
case FETCH_NEGOTIATION_NONE:
|
|
case FETCH_NEGOTIATION_UNSET:
|
|
BUG("FETCH_NEGOTIATION_{NONE,UNSET} used outside of prepare_repo_settings()!");
|
|
}
|
|
}
|