Files
git/Documentation
Martin Ågren de121ffe57 tag: respect pager.tag in list-mode only
Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such as
"Vim: Warning: Output is not to a terminal" and a garbled terminal.
Someone who makes use of both `git tag -a` and `git tag -l` will
probably not set `pager.tag`, so that `git tag -a` will actually work,
at the cost of not paging output of `git tag -l`.

Use the mechanisms introduced in two earlier patches to ignore
`pager.tag` in git.c and let the `git tag` builtin handle it on its own.
Only respect `pager.tag` when running in list-mode.

There is a window between where the pager is started before and after
this patch. This means that early errors can behave slightly different
before and after this patch. Since operation-parsing has to happen
inside this window, this can be seen with `git -c pager.tag="echo pager
is used" tag -l --unknown-option`. This change in paging-behavior should
be acceptable since it only affects erroneous usages.

Update the documentation and update tests.

If an alias is used to run `git tag -a`, then `pager.tag` will still be
respected. Document this known breakage. It will be fixed in a later
commit. Add a similar test for `-l`, which works.

Noticed-by: Anatoly Borodin <anatoly.borodin@gmail.com>
Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2017-08-03 11:08:10 -07:00
..
2017-07-31 13:52:53 -07:00
2016-07-13 11:24:14 -07:00
2016-10-10 14:03:51 -07:00
2017-04-13 16:15:25 -07:00
2017-01-18 15:12:12 -08:00
2015-07-21 14:08:14 -07:00
2016-08-11 14:35:42 -07:00
2017-06-27 10:35:49 -07:00
2015-10-05 12:30:13 -07:00
2017-07-12 15:18:21 -07:00
2017-06-05 09:05:38 +09:00
2017-05-16 11:13:00 +09:00
2017-01-18 15:12:18 -08:00
2017-05-01 11:01:52 +09:00
2017-06-22 15:25:25 -07:00