admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
dda9bff3c55e45ee8dbfb49fd972c4b35fd4ba7e
git/builtin
History
Luke Shumaker dda9bff3c5 fast-export: do not modify memory from get_commit_buffer 
fast-export's helper function find_encoding() takes a `const char *`, but
modifies that memory despite the `const`.  Ultimately, this memory came
from get_commit_buffer(), and you're not supposed to modify the memory
that you get from get_commit_buffer().

So, get rid of find_encoding() in favor of commit.h:find_commit_header(),
which gives back a string length, rather than mutating the memory to
insert a '\0' terminator.

Because find_commit_header() detects the "\n\n" string that separates the
headers and the commit message, move the call to be above the
`message = strstr(..., "\n\n")` call.  This helps readability, and allows
for the value of `encoding` to be used for a better value of "..." so that
the same memory doesn't need to be checked twice.  Introduce a
`commit_buffer_cursor` variable to avoid writing an awkward
`encoding ? encoding + encoding_len : committer_end` expression.

Signed-off-by: Luke Shumaker <lukeshu@datawire.io>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-03-10 13:24:56 -07:00
..
add.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
am.c
Merge branch 'jc/show-usage-help'
2025-01-28 13:02:22 -08:00
annotate.c
Merge branch 'jc/a-commands-without-the-repo'
2024-10-25 14:02:36 -04:00
apply.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
archive.c
archive: remove the_repository global variable
2024-10-11 09:37:18 -07:00
backfill.c
Merge branch 'ds/backfill'
2025-02-18 15:30:31 -08:00
bisect.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
blame.c
Merge branch 'ps/the-repository'
2025-01-21 08:44:54 -08:00
branch.c
Merge branch 'rs/ref-fitler-used-atoms-value-fix'
2025-01-29 14:05:09 -08:00
bugreport.c
diagnose: stop using the_repository
2024-12-18 10:44:31 -08:00
bundle.c
Merge branch 'jt/bundle-fsck'
2024-12-13 07:33:36 -08:00
cat-file.c
Merge branch 'ps/build-sign-compare'
2024-12-23 09:32:11 -08:00
check-attr.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
check-ignore.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
check-mailmap.c
Merge branch 'jc/pass-repo-to-builtins'
2024-09-23 10:35:09 -07:00
check-ref-format.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
checkout--worker.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
checkout-index.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
checkout.c
Merge branch 'ps/build-sign-compare'
2024-12-23 09:32:11 -08:00
clean.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
clone.c
builtin/clone: teach git-clone(1) the --revision= option
2025-02-06 12:26:42 -08:00
column.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
commit-graph.c
progress: stop using the_repository
2024-12-18 10:44:30 -08:00
commit-tree.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
commit.c
Merge branch 'ja/doc-commit-markup-updates'
2025-01-29 14:05:09 -08:00
config.c
builtin: pass repository to sub commands
2024-11-26 10:36:08 +09:00
count-objects.c
packfile: pass down repository to has_object[_kept]_pack
2024-12-04 08:21:54 +09:00
credential-cache--daemon.c
Merge branch 'mh/credential-cache-authtype-request-fix'
2025-01-28 13:02:24 -08:00
credential-cache.c
Merge branch 'rj/cygwin-exit'
2024-11-01 12:53:19 -04:00
credential-store.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
credential.c
Merge branch 'jc/show-usage-help'
2025-01-28 13:02:22 -08:00
describe.c
Merge branch 'ps/build-sign-compare'
2024-12-23 09:32:11 -08:00
diagnose.c
diagnose: stop using the_repository
2024-12-18 10:44:31 -08:00
diff-files.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
diff-index.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
diff-tree.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
diff.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
difftool.c
difftool: eliminate use of USE_THE_REPOSITORY_VARIABLE
2025-02-06 13:00:21 -08:00
fast-export.c
fast-export: do not modify memory from get_commit_buffer
2025-03-10 13:24:56 -07:00
fast-import.c
Merge branch 'ps/hash-cleanup'
2025-02-10 10:18:31 -08:00
fetch-pack.c
oddballs: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
fetch.c
fetch set_head: fix non-mirror remotes in bare repositories
2025-01-27 08:16:47 -08:00
fmt-merge-msg.c
Merge branch 'jc/pass-repo-to-builtins'
2024-09-23 10:35:09 -07:00
for-each-ref.c
ref-filter: remove ref_format_clear()
2025-01-21 09:06:24 -08:00
for-each-repo.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
fsck.c
progress: stop using the_repository
2024-12-18 10:44:30 -08:00
fsmonitor--daemon.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
gc.c
Merge branch 'zh/gc-expire-to'
2025-02-12 10:08:53 -08:00
get-tar-commit-id.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
grep.c
Revert barrier-based LSan threading race workaround
2025-01-01 14:13:01 -08:00
hash-object.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
help.c
pager: stop using the_repository
2024-12-18 10:44:30 -08:00
hook.c
builtin: pass repository to sub commands
2024-11-26 10:36:08 +09:00
index-pack.c
Merge branch 'ps/hash-cleanup'
2025-02-10 10:18:31 -08:00
init-db.c
builtin/init-db: fix leaking directory paths
2024-11-21 08:23:45 +09:00
interpret-trailers.c
trailer: spread usage of "trailer_block" language
2024-10-14 12:33:02 -04:00
log.c
Merge branch 'ps/the-repository'
2025-01-21 08:44:54 -08:00
ls-files.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
ls-remote.c
builtin/ls-remote: plug leaking server options
2024-11-04 22:37:51 -08:00
ls-tree.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
mailinfo.c
mailinfo: stop using the_repository
2024-12-18 10:44:31 -08:00
mailsplit.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
merge-base.c
commit-reach: use size_t to track indices when computing merge bases
2024-12-27 08:12:40 -08:00
merge-file.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
merge-index.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
merge-ours.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
merge-recursive.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
merge-tree.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
merge.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
mktag.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
mktree.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
multi-pack-index.c
midx-write: pass down repository to write_midx_file[_only]
2024-12-04 10:32:20 +09:00
mv.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
name-rev.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
notes.c
builtin: pass repository to sub commands
2024-11-26 10:36:08 +09:00
pack-objects.c
Merge branch 'ds/name-hash-tweaks'
2025-02-12 10:08:51 -08:00
pack-redundant.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
pack-refs.c
diff.h: fix index used to loop through unsigned integer
2024-12-06 20:20:03 +09:00
patch-id.c
global: adapt callers to use generic hash context helpers
2025-01-31 10:06:11 -08:00
prune-packed.c
builtin: remove USE_THE_REPOSITORY for those without the_repository
2024-09-13 14:33:30 -07:00
prune.c
progress: stop using the_repository
2024-12-18 10:44:30 -08:00
pull.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
push.c
remote: rename query_refspecs functions
2025-02-04 09:51:41 -08:00
range-diff.c
Merge branch 'js/range-diff-diff-merges'
2024-12-23 09:32:17 -08:00
read-tree.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
rebase.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
receive-pack.c
Merge branch 'ps/hash-cleanup'
2025-02-10 10:18:31 -08:00
reflog.c
diff.h: fix index used to loop through unsigned integer
2024-12-06 20:20:03 +09:00
refs.c
Merge branch 'kn/pass-repo-to-builtin-sub-sub-commands'
2024-12-04 10:14:47 +09:00
remote-ext.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
remote-fd.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
remote.c
Merge branch 'ms/refspec-cleanup'
2025-02-12 10:08:54 -08:00
repack.c
Merge branch 'ps/repack-keep-unreachable-in-unpacked-repo'
2025-02-12 10:08:52 -08:00
replace.c
refs: allow passing flags when setting up a transaction
2024-11-21 07:59:14 +09:00
replay.c
parse-options: introduce die_for_incompatible_opt2()
2025-02-06 12:23:54 -08:00
rerere.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
reset.c
diff.h: fix index used to loop through unsigned integer
2024-12-06 20:20:03 +09:00
rev-list.c
rev-list: extend print-info to print missing object type
2025-02-05 09:32:01 -08:00
rev-parse.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
revert.c
diff.h: fix index used to loop through unsigned integer
2024-12-06 20:20:03 +09:00
rm.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
send-pack.c
send-pack: stop using the_repository
2024-12-18 10:44:30 -08:00
shortlog.c
diff.h: fix index used to loop through unsigned integer
2024-12-06 20:20:03 +09:00
show-branch.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
show-index.c
Merge branch 'jc/show-index-h-update'
2025-01-31 09:44:16 -08:00
show-ref.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
sparse-checkout.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
stash.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
stripspace.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
submodule--helper.c
global: trivial conversions to fix -Wsign-compare warnings
2024-12-06 20:20:04 +09:00
symbolic-ref.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
tag.c
ref-filter: remove ref_format_clear()
2025-01-21 09:06:24 -08:00
unpack-file.c
oddballs: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
unpack-objects.c
global: adapt callers to use generic hash context helpers
2025-01-31 10:06:11 -08:00
update-index.c
builtins: send usage_with_options() help text to standard output
2025-01-17 13:30:03 -08:00
update-ref.c
global: mark code units that generate warnings with -Wsign-compare
2024-12-06 20:20:02 +09:00
update-server-info.c
builtin/update-server-info: remove the_repository global variable
2025-02-10 16:20:21 -08:00
upload-archive.c
builtin: send usage() help text to standard output
2025-01-17 13:30:03 -08:00
upload-pack.c
serve: stop using the_repository
2024-12-18 10:44:30 -08:00
var.c
Merge branch 'jc/show-usage-help'
2025-01-28 13:02:22 -08:00
verify-commit.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
verify-pack.c
builtin: remove USE_THE_REPOSITORY_VARIABLE from builtin.h
2024-09-13 14:32:24 -07:00
verify-tag.c
ref-filter: remove ref_format_clear()
2025-01-21 09:06:24 -08:00
worktree.c
Merge branch 'ps/build-sign-compare'
2024-12-23 09:32:11 -08:00
write-tree.c
Merge branch 'jc/pass-repo-to-builtins'
2024-09-23 10:35:09 -07:00