admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
c44afd67d2bcfc2958e7cc79d7064ab5fcfa468a
git/t/t0613-reftable-write-options.sh
Jeff King b32c7ec02f test-lib: teach test_seq the -f option 
The "seq" tool has a "-f" option to produce printf-style formatted
lines. Let's teach our test_seq helper the same trick. This lets us get
rid of some shell loops in test snippets (which are particularly verbose
in our test suite because we have to "|| return 1" to keep the &&-chain
going).

This converts a few call-sites I found by grepping around the test
suite. A few notes on these:

  - In "seq", the format specifier is a "%g" float. Since test_seq only
    supports integers, I've kept the more natural "%d" (which is what
    these call sites were using already).

  - Like "seq", test_seq automatically adds a newline to the specified
    format. This is what all callers are doing already except for t0021,
    but there we do not care about the exact format. We are just trying
    to printf a large number of bytes to a file. It's not worth
    complicating other callers or adding an option to avoid the newline
    in that caller.

  - Most conversions are just replacing a shell loop (which does get rid
    of an extra fork, since $() requires a subshell). In t0612 we can
    replace an awk invocation, which I think makes the end result more
    readable, as there's less quoting.

  - In t7422 we can replace one loop, but sadly we have to leave the
    loop directly above it. This is because that earlier loop wants to
    include the seq value twice in the output, which test_seq does not
    support (nor does regular seq). If you run:

      test_seq -f "foo-%d %d" 10

    the second "%d" will always be the empty string. You might naively
    think that test_seq could add some extra arguments, like:

      # 3 ought to be enough for anyone...
      printf "$fmt\n" "$i "$i" $i"

    but that just triggers printf to format multiple lines, one per
    extra set of arguments.

    So we'd have to actually parse the format string, figure out how
    many "%" placeholders are there, and then feed it that many
    instances of the sequence number. The complexity isn't worth it.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2025-06-24 06:34:25 -07:00

280 lines
6.2 KiB
Bash
Executable File
Raw Blame History

#!/bin/sh
test_description='reftable write options'
GIT_TEST_DEFAULT_REF_FORMAT=reftable
export GIT_TEST_DEFAULT_REF_FORMAT
# Disable auto-compaction for all tests as we explicitly control repacking of
# refs.
GIT_TEST_REFTABLE_AUTOCOMPACTION=false
export GIT_TEST_REFTABLE_AUTOCOMPACTION
# Block sizes depend on the hash function, so we force SHA1 here.
GIT_TEST_DEFAULT_HASH=sha1
export GIT_TEST_DEFAULT_HASH
# Block sizes also depend on the actual refs we write, so we force "master" to
# be the default initial branch name.
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=master
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
. ./test-lib.sh
test_expect_success 'default write options' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
git pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 4096
ref:
- length: 129
restarts: 2
log:
- length: 262
restarts: 2
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'disabled reflog writes no log blocks' '
test_config_global core.logAllRefUpdates false &&
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
git pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 4096
ref:
- length: 129
restarts: 2
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'many refs results in multiple blocks' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
test_seq -f "update refs/heads/branch-%d HEAD" 200 >input &&
git update-ref --stdin <input &&
git pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 4096
ref:
- length: 4049
restarts: 11
- length: 1136
restarts: 3
log:
- length: 4041
restarts: 4
- length: 4015
restarts: 3
- length: 4014
restarts: 3
- length: 4012
restarts: 3
- length: 3289
restarts: 3
idx:
- length: 103
restarts: 1
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'tiny block size leads to error' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
cat >expect <<-EOF &&
error: unable to compact stack: entry too large
EOF
test_must_fail git -c reftable.blockSize=50 pack-refs 2>err &&
test_cmp expect err
)
'
test_expect_success 'small block size leads to multiple ref blocks' '
test_config_global core.logAllRefUpdates false &&
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit A &&
test_commit B &&
git -c reftable.blockSize=100 pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 100
ref:
- length: 53
restarts: 1
- length: 74
restarts: 1
- length: 38
restarts: 1
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'small block size fails with large reflog message' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit A &&
test-tool genzeros 500 | tr "\000" "a" >logmsg &&
cat >expect <<-EOF &&
fatal: update_ref failed for ref ${SQ}refs/heads/logme${SQ}: reftable: transaction failure: entry too large
EOF
test_must_fail git -c reftable.blockSize=100 \
update-ref -m "$(cat logmsg)" refs/heads/logme HEAD 2>err &&
test_cmp expect err
)
'
test_expect_success 'block size exceeding maximum supported size' '
test_config_global core.logAllRefUpdates false &&
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit A &&
test_commit B &&
cat >expect <<-EOF &&
fatal: reftable block size cannot exceed 16MB
EOF
test_must_fail git -c reftable.blockSize=16777216 pack-refs 2>err &&
test_cmp expect err
)
'
test_expect_success 'restart interval at every single record' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
test_seq -f "update refs/heads/branch-%d HEAD" 10 >input &&
git update-ref --stdin <input &&
git -c reftable.restartInterval=1 pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 4096
ref:
- length: 566
restarts: 13
log:
- length: 1393
restarts: 12
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'restart interval exceeding maximum supported interval' '
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
cat >expect <<-EOF &&
fatal: reftable block size cannot exceed 65535
EOF
test_must_fail git -c reftable.restartInterval=65536 pack-refs 2>err &&
test_cmp expect err
)
'
test_expect_success 'object index gets written by default with ref index' '
test_config_global core.logAllRefUpdates false &&
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
test_seq -f "update refs/heads/branch-%d HEAD" 5 >input &&
git update-ref --stdin <input &&
git -c reftable.blockSize=100 pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 100
ref:
- length: 53
restarts: 1
- length: 95
restarts: 1
- length: 71
restarts: 1
- length: 80
restarts: 1
idx:
- length: 55
restarts: 2
obj:
- length: 11
restarts: 1
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_expect_success 'object index can be disabled' '
test_config_global core.logAllRefUpdates false &&
test_when_finished "rm -rf repo" &&
git init repo &&
(
cd repo &&
test_commit initial &&
test_seq -f "update refs/heads/branch-%d HEAD" 5 >input &&
git update-ref --stdin <input &&
git -c reftable.blockSize=100 -c reftable.indexObjects=false pack-refs &&
cat >expect <<-EOF &&
header:
block_size: 100
ref:
- length: 53
restarts: 1
- length: 95
restarts: 1
- length: 71
restarts: 1
- length: 80
restarts: 1
idx:
- length: 55
restarts: 2
EOF
test-tool dump-reftable -b .git/reftable/*.ref >actual &&
test_cmp expect actual
)
'
test_done
Reference in New Issue View Git Blame Copy Permalink