Junio C Hamano
6694856153
commit-tree: do not pay attention to commit.gpgsign
...
ba3c69a9 (commit: teach --gpg-sign option, 2011-10-05) introduced a
"signed commit" by teaching the --[no]-gpg-sign option and the
commit.gpgsign configuration variable to various commands that
create commits.
Teaching these to "git commit" and "git merge", both of which are
end-user facing Porcelain commands, was perfectly fine. Allowing
the plumbing "git commit-tree" to suddenly change the behaviour to
surprise the scripts by paying attention to commit.gpgsign was not.
Among the in-tree scripts, filter-branch, quiltimport, rebase and
stash are the commands that run "commit-tree". If any of these
wants to allow users to always sign every single commit, they should
offer their own configuration (e.g. "filterBranch.gpgsign") with an
option to disable signing (e.g. "git filter-branch --no-gpgsign").
Ignoring commit.gpgsign option _obviously_ breaks the backward
compatibility, but it is easy to follow the standard pattern in
scripts to honor whatever configuration variable they choose to
follow. E.g.
case $(git config --bool commit.gpgsign) in
true) sign=-S ;;
*) sign= ;;
esac &&
git commit-tree $sign ...whatever other args...
Do so to make sure that "git rebase" keeps paying attention to the
configuration variable, which unfortunately is a documented mistake.
Helped-by: Jeff King <peff@peff.net >
Signed-off-by: Junio C Hamano <gitster@pobox.com >
2016-05-03 10:59:25 -07:00
..
2015-04-01 22:44:03 -07:00
2016-03-17 11:23:05 -07:00
2015-06-25 11:02:14 -07:00
2013-02-02 21:46:52 -08:00
2013-02-01 13:53:25 -08:00
2015-05-11 14:39:28 -07:00
2013-04-03 16:14:19 -07:00
2015-04-21 12:12:19 -07:00
2015-06-25 11:02:11 -07:00
2013-11-12 10:47:17 -08:00
2015-03-13 22:13:46 -07:00
2015-01-28 22:22:03 -08:00
2015-05-12 22:13:39 -07:00
2015-06-16 14:33:43 -07:00
2010-08-20 10:53:56 -07:00
2014-10-10 16:02:26 -07:00
2015-03-13 22:13:46 -07:00
2015-05-28 12:38:46 -07:00
2015-06-05 12:00:19 -07:00
2015-03-06 14:57:56 -08:00
2011-07-06 14:26:26 -07:00
2015-03-13 22:13:46 -07:00
2013-02-01 13:53:33 -08:00
2014-02-28 09:55:35 -08:00
2014-11-04 13:14:44 -08:00
2014-05-21 13:57:10 -07:00
2014-02-11 11:03:07 -08:00
2015-07-27 12:21:46 -07:00
2013-02-01 13:53:33 -08:00
2013-12-26 11:54:26 -08:00
2013-09-04 12:23:25 -07:00
2015-03-13 22:13:46 -07:00
2013-07-13 10:19:37 -07:00
2013-09-12 14:39:34 -07:00
2011-03-11 10:59:16 -05:00
2015-06-17 13:33:06 -07:00
2015-03-30 21:49:51 -07:00
2013-11-27 12:16:49 -08:00
2011-07-06 14:26:26 -07:00
2015-03-13 22:56:12 -07:00
2014-10-15 14:34:45 -07:00
2014-01-27 08:34:34 -08:00
2016-05-03 10:59:25 -07:00
2015-06-16 14:33:49 -07:00
2015-03-13 22:13:46 -07:00
2014-03-31 15:16:22 -07:00
2014-09-16 11:11:58 -07:00
2013-02-01 13:53:33 -08:00
2015-03-24 08:08:02 -07:00
2013-09-06 14:49:06 -07:00
2013-02-01 13:53:33 -08:00
2014-11-04 13:14:44 -08:00
2015-03-13 22:13:46 -07:00
2014-05-21 13:57:10 -07:00
2015-06-16 13:19:34 -07:00
2011-07-06 14:26:26 -07:00
2013-05-20 15:50:44 -07:00
2011-05-26 22:15:39 -07:00
2014-03-31 15:16:22 -07:00
2014-10-28 10:36:57 -07:00
2015-05-12 22:14:46 -07:00
2015-05-12 22:14:46 -07:00
2015-05-12 22:14:46 -07:00
2015-03-13 22:13:46 -07:00
2014-11-04 13:14:44 -08:00
2015-05-28 12:38:46 -07:00
2014-01-27 08:34:34 -08:00
2015-07-15 11:41:22 -07:00
2011-07-06 14:26:26 -07:00
2013-05-17 12:09:21 -07:00
2015-03-13 22:13:46 -07:00
2011-07-06 14:26:26 -07:00
2014-03-20 12:38:00 -07:00
2013-02-01 13:53:33 -08:00
2015-05-04 14:19:23 -07:00
2014-05-21 13:57:10 -07:00
2015-06-16 14:33:45 -07:00
2013-02-01 13:53:33 -08:00
2011-07-06 14:26:26 -07:00
2015-03-10 15:19:05 -07:00
2013-05-28 08:07:20 -07:00
2013-02-01 13:53:33 -08:00
2015-03-13 22:13:46 -07:00
2015-03-13 22:13:46 -07:00
2014-11-04 13:14:44 -08:00
2015-05-11 14:39:28 -07:00
2014-05-21 13:57:10 -07:00
2013-06-23 00:33:58 -07:00
2011-03-11 10:59:16 -05:00
2014-11-25 15:24:55 -08:00
2011-07-06 14:26:26 -07:00
2013-10-29 13:06:08 -07:00
2013-08-09 14:19:59 -07:00
2013-04-15 11:08:37 -07:00
2011-07-06 14:26:26 -07:00
2013-09-04 15:02:56 -07:00
2015-03-13 22:13:46 -07:00
2013-02-01 13:53:33 -08:00
2014-04-24 11:29:05 -07:00
2013-02-01 13:53:33 -08:00
2011-07-06 14:26:26 -07:00
2014-01-07 14:33:04 -08:00
2013-09-04 15:03:03 -07:00
2014-11-12 11:00:11 -08:00
2015-02-11 13:38:29 -08:00
2015-05-12 22:14:46 -07:00
2011-07-06 14:26:26 -07:00
2013-07-18 16:23:46 -07:00
2011-07-06 14:26:26 -07:00
2014-06-10 13:09:24 -07:00
2014-10-13 13:35:18 -07:00
2014-03-31 15:16:22 -07:00
2015-03-28 09:37:52 -07:00
2015-06-05 12:00:19 -07:00
2014-10-13 13:35:18 -07:00
2014-05-21 13:57:10 -07:00
2015-06-05 12:00:19 -07:00
2015-03-13 22:13:46 -07:00
2015-03-05 12:35:37 -08:00
2011-07-06 14:26:26 -07:00
2014-11-11 14:47:04 -08:00
2014-11-11 14:47:04 -08:00
2013-02-01 14:12:34 -08:00
2013-02-07 14:41:45 -08:00
2015-03-13 22:56:05 -07:00
2015-03-13 22:13:46 -07:00
2014-07-27 15:14:18 -07:00
2014-03-13 14:22:20 -07:00
2015-03-13 22:13:46 -07:00
2014-04-08 12:00:28 -07:00
2015-07-01 09:29:11 -07:00
2015-05-12 22:14:46 -07:00
2014-03-24 10:43:34 -07:00
2014-01-07 14:34:06 -08:00
2015-03-13 22:13:46 -07:00
2015-06-05 12:00:19 -07:00
2012-03-28 11:18:35 -07:00
2011-09-11 21:52:18 -07:00
2013-10-18 13:50:12 -07:00
2014-05-08 10:26:26 -07:00
2013-04-21 23:11:02 -07:00
2014-03-31 15:16:22 -07:00
2013-04-15 11:08:37 -07:00
2014-03-31 15:16:22 -07:00
2015-05-12 22:14:46 -07:00
2014-10-13 13:35:18 -07:00
2014-02-24 09:13:30 -08:00
2015-04-28 13:00:18 -07:00
2015-06-05 12:00:21 -07:00
2015-05-28 15:18:11 -07:00
2015-05-12 22:14:46 -07:00
2012-10-21 12:17:38 -07:00
2015-06-05 12:00:19 -07:00
2013-04-12 12:00:52 -07:00
2011-07-06 14:26:26 -07:00
2015-05-22 09:00:17 -07:00
2014-12-22 12:27:38 -08:00
2014-04-07 12:09:13 -07:00
2011-07-06 14:26:26 -07:00
2014-02-28 09:55:37 -08:00
2013-02-01 13:53:33 -08:00
2013-02-01 13:53:33 -08:00
2014-06-23 15:50:31 -07:00
2015-05-17 11:24:57 -07:00
2013-04-15 11:08:37 -07:00
2014-05-21 13:57:10 -07:00
2013-08-13 09:01:54 -07:00
2011-07-06 14:26:26 -07:00
2016-03-17 11:23:05 -07:00
2015-03-13 22:13:46 -07:00
2014-05-21 13:57:10 -07:00
2015-06-05 12:00:22 -07:00
2015-03-13 22:13:46 -07:00
2014-10-10 16:02:26 -07:00
2015-05-12 22:14:46 -07:00
2014-10-10 16:02:26 -07:00
2014-10-10 16:02:26 -07:00
2015-01-08 14:28:43 -08:00
2015-03-13 22:13:46 -07:00
2015-04-20 11:05:50 -07:00
2015-03-02 14:59:55 -08:00
2013-02-01 13:53:33 -08:00
2015-05-12 22:14:46 -07:00
2014-06-13 11:49:39 -07:00
2013-02-01 13:53:33 -08:00
2014-11-19 13:47:59 -08:00
2014-11-19 13:47:59 -08:00
2015-04-21 12:12:22 -07:00
2014-02-20 14:14:58 -08:00
2013-02-01 13:53:33 -08:00
2015-05-29 13:36:47 -07:00
2014-04-17 11:14:57 -07:00
2013-02-01 13:53:33 -08:00
2011-11-08 13:37:10 -08:00
2014-04-17 11:14:58 -07:00
2015-04-20 11:05:50 -07:00
2013-01-05 23:41:42 -08:00
2015-01-22 13:44:14 -08:00
2009-12-05 10:03:49 -08:00
2015-06-25 11:02:17 -07:00
2014-03-31 15:16:22 -07:00
2014-04-03 13:39:03 -07:00
2015-06-16 14:33:43 -07:00
2015-07-27 12:21:48 -07:00
2014-06-12 09:59:13 -07:00
2015-04-28 13:00:20 -07:00
2014-05-13 12:35:00 -07:00
2011-11-22 18:16:59 -08:00
2015-03-28 09:33:10 -07:00
2013-02-01 13:53:33 -08:00
2013-07-21 22:51:24 -07:00
2012-08-07 14:30:52 -07:00
2015-03-13 22:13:46 -07:00