Files
git/Documentation
Martin Ågren 2afe9278a2 doc-diff: don't cd_to_toplevel
`usage` tries to call $0, which might very well be "./doc-diff", so if
we `cd_to_toplevel` before calling `usage`, we'll end with an error to
the effect of "./doc-diff: not found" rather than a friendly `doc-diff
-h` output. This regressed in ad51743007 ("doc-diff: add --clean mode to
remove temporary working gunk", 2018-08-31) where we moved the call to
`cd_to_toplevel` to much earlier.

A general fix might be to teach git-sh-setup to save away the absolute
path for $0 and then use that, instead. I'm not aware of any portable
way of doing that, see, e.g., d2addc3b96 ("t7800: readlink may not be
available", 2016-05-31).

An early version of this patch moved `cd_to_toplevel` back to where it
was before ad51743007 and taught the "--clean" code to cd on its own.
But let's try instead to get rid of the cd-ing entirely. We don't really
need it and we can work with absolute paths instead. There's just one
use of $PWD that we need to adjust by simply dropping it.

Suggested-by: Jeff King <peff@peff.net>
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2019-02-04 13:12:37 -08:00
..
2018-08-02 15:38:09 -07:00
2019-02-04 13:12:37 -08:00
2018-06-25 13:22:36 -07:00
2018-06-22 13:19:33 -07:00
2018-05-23 14:38:22 +09:00
2018-06-27 10:29:10 -07:00
2018-06-18 10:18:41 -07:00
2016-08-11 14:35:42 -07:00
2017-06-27 10:35:49 -07:00
2018-06-01 15:06:37 +09:00
2018-04-18 12:49:26 +09:00