admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
26b8abc7b14754d32d994f87a45b303873565853
git/builtin
History
Sean Allred 26b8abc7b1 var: do not print usage() with a correct invocation 
Before, git-var could print usage() even if the command was invoked
correctly with a variable defined in git_vars -- provided that its
read() function returned NULL.

Now, we only print usage() only if it was called with a logical
variable that wasn't defined -- regardless of read().

Since we now know the variable is valid when we call read_var(), we
can avoid printing usage() here (and exiting with code 129) and
instead exit quietly with code 1. While exiting with a different code
can be a breaking change, it's far better than changing the exit
status more generally from 'failure' to 'success'.

Signed-off-by: Sean Allred <allred.sean@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2022-11-27 09:35:55 +09:00
..
add.c
use child_process members "args" and "env" directly
2022-10-30 14:04:40 -04:00
am.c
replace and remove run_command_v_opt()
2022-10-30 14:04:51 -04:00
annotate.c
…
apply.c
apply.c: remove unnecessary include
2022-04-06 09:42:14 -07:00
archive.c
parse-options: PARSE_OPT_KEEP_UNKNOWN only applies to --options
2022-08-19 11:13:14 -07:00
bisect--helper.c
Merge branch 'dd/bisect-helper-subcommand'
2022-11-23 11:22:22 +09:00
blame.c
doc txt & -h consistency: make "annotate" consistent
2022-10-13 09:32:57 -07:00
branch.c
branch: gracefully handle '-d' on orphan HEAD
2022-11-10 21:42:45 -05:00
bugreport.c
doc txt & -h consistency: fix mismatching labels
2022-10-13 09:32:56 -07:00
bundle.c
Merge branch 'ds/bundle-uri-3'
2022-10-30 21:04:44 -04:00
cat-file.c
doc txt & -h consistency: add "-z" to cat-file "-h"
2022-10-13 09:32:55 -07:00
check-attr.c
…
check-ignore.c
…
check-mailmap.c
…
check-ref-format.c
check-ref-format: fix trivial memory leak
2022-07-01 11:43:42 -07:00
checkout--worker.c
…
checkout-index.c
…
checkout.c
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
2022-09-01 10:49:48 -07:00
clean.c
doc txt & -h consistency: use "[<label>...]" for "zero or more"
2022-10-13 09:32:57 -07:00
clone.c
replace and remove run_command_v_opt()
2022-10-30 14:04:51 -04:00
column.c
…
commit-graph.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
commit-tree.c
doc txt & -h consistency: add missing options
2022-10-13 09:32:57 -07:00
commit.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
config.c
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
2022-09-01 10:49:48 -07:00
count-objects.c
…
credential-cache--daemon.c
doc txt & -h consistency: use "git foo" form, not "git-foo"
2022-10-13 09:32:57 -07:00
credential-cache.c
…
credential-store.c
…
credential.c
…
describe.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
diagnose.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
diff-files.c
built-ins: consistently add "\n" between "usage" and options
2022-10-13 09:32:54 -07:00
diff-index.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
diff-tree.c
doc txt & -h consistency: make "diff-tree" consistent
2022-10-13 09:32:57 -07:00
diff.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
difftool.c
replace and remove run_command_v_opt()
2022-10-30 14:04:51 -04:00
env--helper.c
parse-options: PARSE_OPT_KEEP_UNKNOWN only applies to --options
2022-08-19 11:13:14 -07:00
fast-export.c
Merge branch 'ab/unused-annotation'
2022-09-14 12:56:39 -07:00
fast-import.c
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
2022-09-01 10:49:48 -07:00
fetch-pack.c
list-objects-filter: add and use initializers
2022-09-12 08:38:59 -07:00
fetch.c
Merge branch 'rs/no-more-run-command-v'
2022-11-08 17:15:12 -05:00
fmt-merge-msg.c
…
for-each-ref.c
…
for-each-repo.c
for-each-repo: interpolate repo path arguments
2022-11-14 22:39:25 -05:00
fsck.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
fsmonitor--daemon.c
Merge branch 'ed/fsmonitor-on-networked-macos'
2022-10-17 14:56:31 -07:00
gc.c
Merge branch 'rp/maintenance-qol'
2022-11-23 11:22:24 +09:00
get-tar-commit-id.c
…
grep.c
builtin/grep.c: integrate with sparse index
2022-09-23 09:41:27 -07:00
hash-object.c
doc txt & -h consistency: add missing options
2022-10-13 09:32:57 -07:00
help.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
hook.c
builtin/hook.c: let parse-options parse subcommands
2022-08-19 11:13:15 -07:00
index-pack.c
i18n: fix mismatched camelCase config variables
2022-06-17 10:38:26 -07:00
init-db.c
doc txt & -h consistency: add missing options
2022-10-13 09:32:57 -07:00
interpret-trailers.c
doc txt & -h consistency: add missing options
2022-10-13 09:32:57 -07:00
log.c
Merge branch 'tb/shortlog-group'
2022-10-30 21:04:42 -04:00
ls-files.c
ls-files: fix black space in error message
2022-09-12 09:25:40 -07:00
ls-remote.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
ls-tree.c
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
2022-09-01 10:49:48 -07:00
mailinfo.c
…
mailsplit.c
Merge branch 'ep/maint-equals-null-cocci'
2022-05-20 15:26:59 -07:00
merge-base.c
doc txt & -h consistency: make output order consistent
2022-10-13 09:32:56 -07:00
merge-file.c
merge-file: fix memory leaks on error path
2022-07-01 11:43:43 -07:00
merge-index.c
replace and remove run_command_v_opt()
2022-10-30 14:04:51 -04:00
merge-ours.c
…
merge-recursive.c
gettext API users: don't explicitly cast ngettext()'s "n"
2022-03-07 11:57:52 -08:00
merge-tree.c
merge-tree: support multiple batched merges with --stdin
2022-10-22 22:21:26 -07:00
merge.c
use child_process members "args" and "env" directly
2022-10-30 14:04:40 -04:00
mktag.c
Merge branch 'ab/object-file-api-updates'
2022-03-16 17:53:08 -07:00
mktree.c
mktree: do not check type of remote objects
2022-06-21 10:12:15 -07:00
multi-pack-index.c
multi-pack-index: avoid writing to global in option callback
2022-10-06 09:56:51 -07:00
mv.c
Merge branch 'sy/mv-out-of-cone'
2022-09-19 14:35:23 -07:00
name-rev.c
git-compat-util.h: use "UNUSED", not "UNUSED(var)"
2022-09-01 10:49:48 -07:00
notes.c
notes: avoid empty line in template
2022-11-16 14:57:32 -05:00
pack-objects.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
pack-redundant.c
doc txt & -h consistency: fix mismatching labels
2022-10-13 09:32:56 -07:00
pack-refs.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
patch-id.c
builtin: patch-id: remove unused diff-tree prefix
2022-10-24 15:44:20 -07:00
prune-packed.c
…
prune.c
revisions API users: add straightforward release_revisions()
2022-04-13 23:56:08 -07:00
pull.c
use child_process members "args" and "env" directly
2022-10-30 14:04:40 -04:00
push.c
Doc: document push.recurseSubmodules=only
2022-11-14 16:55:50 -05:00
range-diff.c
range-diff: optionally accept pathspecs
2022-08-26 09:49:26 -07:00
read-tree.c
read-tree: use 'skip_cache_tree_update' option
2022-11-10 21:49:34 -05:00
rebase.c
rebase: stop exporting GIT_REFLOG_ACTION
2022-11-09 18:15:54 -05:00
receive-pack.c
receive-pack: only use visible refs for connectivity check
2022-11-17 16:22:52 -05:00
reflog.c
refs: unify parse_worktree_ref() and ref_type()
2022-09-19 11:11:11 -07:00
remote-ext.c
…
remote-fd.c
…
remote.c
Merge branch 'rs/no-more-run-command-v'
2022-11-08 17:15:12 -05:00
repack.c
Merge branch 'tb/repack-expire-to'
2022-11-18 18:43:09 -05:00
replace.c
refs: use ref_namespaces for replace refs base
2022-08-05 14:13:12 -07:00
rerere.c
doc txt & -h consistency: make "rerere" consistent
2022-10-13 09:32:56 -07:00
reset.c
reset: use 'skip_cache_tree_update' option
2022-11-10 21:49:34 -05:00
rev-list.c
Merge branch 'ps/receive-use-only-advertised'
2022-11-23 11:22:25 +09:00
rev-parse.c
rev-parse: add --exclude-hidden= option
2022-11-17 16:22:52 -05:00
revert.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
rm.c
submodule API & "absorbgitdirs": remove "----recursive" option
2022-11-08 14:55:30 -05:00
send-pack.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
shortlog.c
shortlog: implement --group=committer in terms of --group=<format>
2022-10-24 14:48:05 -07:00
show-branch.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
show-index.c
…
show-ref.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
sparse-checkout.c
doc txt & -h consistency: use "<options>", not "<options>..."
2022-10-13 09:32:55 -07:00
stash.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
stripspace.c
…
submodule--helper.c
submodule--helper: use OPT_SUBCOMMAND() API
2022-11-08 14:55:30 -05:00
symbolic-ref.c
Merge branch 'ab/doc-synopsis-and-cmd-usage'
2022-10-28 11:26:54 -07:00
tag.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
unpack-file.c
doc txt & -h consistency: fix mismatching labels
2022-10-13 09:32:56 -07:00
unpack-objects.c
unpack-objects: use stream_loose_object() to unpack large objects
2022-06-13 10:22:36 -07:00
update-index.c
update-index: drop unused argc from do_reupdate()
2022-10-17 21:24:03 -07:00
update-ref.c
…
update-server-info.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
upload-archive.c
doc txt & -h consistency: fix mismatching labels
2022-10-13 09:32:56 -07:00
upload-pack.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
var.c
var: do not print usage() with a correct invocation
2022-11-27 09:35:55 +09:00
verify-commit.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
verify-pack.c
doc txt & -h consistency: add or fix optional "--" syntax
2022-10-13 09:32:56 -07:00
verify-tag.c
doc txt & -h consistency: add missing options and labels
2022-10-13 09:32:56 -07:00
worktree.c
doc txt & -h consistency: make "worktree" consistent
2022-10-13 09:32:58 -07:00
write-tree.c
…