Files
git/builtin
Eric Sunshine 164a9cf430 blame: fix -L bounds checking bug
Since inception, -LX,Y has correctly reported an out-of-range error when
Y is beyond end of file, however, X was not checked, and an out-of-range
X would cause a crash.  92f9e273 (blame: prevent a segv when -L given
start > EOF; 2010-02-08) attempted to rectify this shortcoming but has
its own off-by-one error which allows X to extend one line past end of
file.  For example, given a file with 5 lines:

  git blame -L5 foo  # OK, blames line 5
  git blame -L6 foo  # accepted, no error, no output, huh?
  git blame -L7 foo  # error "fatal: file foo has only 5 lines"

Fix this bug.

In order to avoid regressing "blame foo" when foo is an empty file, the
fix is slightly more complicated than changing '<' to '<='.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
2013-08-05 11:54:31 -07:00
..
2013-07-22 11:23:10 -07:00
2013-07-22 11:34:25 -07:00
2013-08-05 11:54:31 -07:00
2013-04-15 11:04:44 -07:00
2012-09-17 15:59:34 -07:00
2013-05-29 14:23:40 -07:00
2013-08-01 11:52:37 -07:00
2013-07-22 11:24:09 -07:00
2013-07-29 12:32:25 -07:00
2013-06-14 08:46:14 -07:00
2012-09-27 17:57:26 -07:00
2013-07-22 11:24:11 -07:00
2013-07-22 11:24:11 -07:00
2012-10-25 06:42:27 -04:00
2013-07-29 12:32:25 -07:00
2013-05-29 14:23:04 -07:00
2013-06-17 13:30:01 -07:00
2013-07-19 09:26:15 -07:00
2013-07-22 11:23:56 -07:00
2013-01-16 12:48:22 -08:00