The implementation of `git pack-refs` is monolithic within `cmd_pack_refs()`, making it impossible to share its logic with other commands. To enable code reuse for the upcoming `git refs optimize` subcommand, refactor the core logic into a shared helper function. Split the original `builtin/pack-refs.c` file into two parts: - A new shared library file, `pack-refs.c`, which contains the core option parsing and packing logic in a new `pack_refs_core()` helper function. - The original `builtin/pack-refs.c`, which is now a thin wrapper responsible only for defining the `git pack-refs` command and calling the shared helper. A new `pack-refs.h` header is also introduced to define the public interface for this shared logic. Mentored-by: Patrick Steinhardt <ps@pks.im> Mentored-by: shejialuo <shejialuo@gmail.com> Signed-off-by: Meet Soni <meetsoni3017@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
57 lines
1.8 KiB
C
57 lines
1.8 KiB
C
#include "builtin.h"
|
|
#include "config.h"
|
|
#include "environment.h"
|
|
#include "pack-refs.h"
|
|
#include "parse-options.h"
|
|
#include "refs.h"
|
|
#include "revision.h"
|
|
|
|
int pack_refs_core(int argc,
|
|
const char **argv,
|
|
const char *prefix,
|
|
struct repository *repo,
|
|
const char * const *usage_opts)
|
|
{
|
|
struct ref_exclusions excludes = REF_EXCLUSIONS_INIT;
|
|
struct string_list included_refs = STRING_LIST_INIT_NODUP;
|
|
struct pack_refs_opts pack_refs_opts = {
|
|
.exclusions = &excludes,
|
|
.includes = &included_refs,
|
|
.flags = PACK_REFS_PRUNE,
|
|
};
|
|
struct string_list option_excluded_refs = STRING_LIST_INIT_NODUP;
|
|
struct string_list_item *item;
|
|
int pack_all = 0;
|
|
int ret;
|
|
|
|
struct option opts[] = {
|
|
OPT_BOOL(0, "all", &pack_all, N_("pack everything")),
|
|
OPT_BIT(0, "prune", &pack_refs_opts.flags, N_("prune loose refs (default)"), PACK_REFS_PRUNE),
|
|
OPT_BIT(0, "auto", &pack_refs_opts.flags, N_("auto-pack refs as needed"), PACK_REFS_AUTO),
|
|
OPT_STRING_LIST(0, "include", pack_refs_opts.includes, N_("pattern"),
|
|
N_("references to include")),
|
|
OPT_STRING_LIST(0, "exclude", &option_excluded_refs, N_("pattern"),
|
|
N_("references to exclude")),
|
|
OPT_END(),
|
|
};
|
|
repo_config(repo, git_default_config, NULL);
|
|
if (parse_options(argc, argv, prefix, opts, usage_opts, 0))
|
|
usage_with_options(usage_opts, opts);
|
|
|
|
for_each_string_list_item(item, &option_excluded_refs)
|
|
add_ref_exclusion(pack_refs_opts.exclusions, item->string);
|
|
|
|
if (pack_all)
|
|
string_list_append(pack_refs_opts.includes, "*");
|
|
|
|
if (!pack_refs_opts.includes->nr)
|
|
string_list_append(pack_refs_opts.includes, "refs/tags/*");
|
|
|
|
ret = refs_optimize(get_main_ref_store(repo), &pack_refs_opts);
|
|
|
|
clear_ref_exclusions(&excludes);
|
|
string_list_clear(&included_refs, 0);
|
|
string_list_clear(&option_excluded_refs, 0);
|
|
return ret;
|
|
}
|