admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

trace2: avoid "futile conditional"

Browse Source 
CodeQL reports empty `if` blocks that only contain a comment as "futile
conditional". The comment talks about potential plans to turn this into
a warning, but that seems not to have been necessary. Replace the entire
construct with a concise comment.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin
2025-05-15 13:11:46 +00:00
committed by Junio C Hamano
parent 3d39bcd98e
commit fc451e6ea8
1 changed files with 5 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
trace2/tr2_tmr.c
View File

@@ -102,25 +102,11 @@ void tr2_update_final_timers(void)
struct tr2_timer *t_final = &final_timer_block.timer[tid]; struct tr2_timer *t_final = &final_timer_block.timer[tid];
struct tr2_timer *t = &ctx->timer_block.timer[tid]; struct tr2_timer *t = &ctx->timer_block.timer[tid];
if (t->recursion_count) { /*
/* * `t->recursion_count` could technically be non-zero, which
* The current thread is exiting with * would constitute a bug. Reporting the bug would potentially
* timer[tid] still running. * cause an infinite recursion, though, so let's ignore it.
* */
* Technically, this is a bug, but I'm going
* to ignore it.
*
* I don't think it is worth calling die()
* for. I don't think it is worth killing the
* process for this bookkeeping error. We
* might want to call warning(), but I'm going
* to wait on that.
*
* The downside here is that total_ns won't
* include the current open interval (now -
* start_ns). I can live with that.
*/
}
if (!t->interval_count) if (!t->interval_count)
continue; /* this timer was not used by this thread */ continue; /* this timer was not used by this thread */