admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

packfile: pass down repository to has_object[_kept]_pack

Browse Source 
The functions `has_object[_kept]_pack` currently rely on the global
variable `the_repository`. To eliminate global variable usage in
`packfile.c`, we should progressively shift the dependency on
the_repository to higher layers. Let's remove its usage from these
functions and any related ones.

Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Karthik Nayak
2024-12-03 15:43:59 +01:00
committed by Junio C Hamano
parent 873b00597b
commit cc656f4eb2
11 changed files with 21 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packfile.c
View File

@@ -2143,16 +2143,17 @@ int find_kept_pack_entry(struct repository *r,
return 0;
}
int has_object_pack(const struct object_id *oid)
int has_object_pack(struct repository *r, const struct object_id *oid)
{
struct pack_entry e;
return find_pack_entry(the_repository, oid, &e);
return find_pack_entry(r, oid, &e);
}
int has_object_kept_pack(const struct object_id *oid, unsigned flags)
int has_object_kept_pack(struct repository *r, const struct object_id *oid,
unsigned flags)
{
struct pack_entry e;
return find_kept_pack_entry(the_repository, oid, flags, &e);
return find_kept_pack_entry(r, oid, flags, &e);
}
int for_each_object_in_pack(struct packed_git *p,