Sync with 2.30.9
* maint-2.30: (23 commits) Git 2.30.9 gettext: avoid using gettext if the locale dir is not present apply --reject: overwrite existing `.rej` symlink if it exists http.c: clear the 'finished' member once we are done with it clone.c: avoid "exceeds maximum object size" error with GCC v12.x range-diff: use ssize_t for parsed "len" in read_patches() range-diff: handle unterminated lines in read_patches() range-diff: drop useless "offset" variable from read_patches() t5604: GETTEXT_POISON fix, conclusion t5604: GETTEXT_POISON fix, part 1 t5619: GETTEXT_POISON fix t0003: GETTEXT_POISON fix, conclusion t0003: GETTEXT_POISON fix, part 1 t0033: GETTEXT_POISON fix http: support CURLOPT_PROTOCOLS_STR http: prefer CURLOPT_SEEKFUNCTION to CURLOPT_IOCTLFUNCTION http-push: prefer CURLOPT_UPLOAD to CURLOPT_PUT ci: install python on ubuntu ci: use the same version of p4 on both Linux and macOS ci: remove the pipe after "p4 -V" to catch errors github-actions: run gcc-8 on ubuntu-20.04 image ...
This commit is contained in:
29
range-diff.c
29
range-diff.c
@@ -26,17 +26,6 @@ struct patch_util {
|
||||
struct object_id oid;
|
||||
};
|
||||
|
||||
static size_t find_end_of_line(char *buffer, unsigned long size)
|
||||
{
|
||||
char *eol = memchr(buffer, '\n', size);
|
||||
|
||||
if (!eol)
|
||||
return size;
|
||||
|
||||
*eol = '\0';
|
||||
return eol + 1 - buffer;
|
||||
}
|
||||
|
||||
/*
|
||||
* Reads the patches into a string list, with the `util` field being populated
|
||||
* as struct object_id (will need to be free()d).
|
||||
@@ -49,7 +38,7 @@ static int read_patches(const char *range, struct string_list *list,
|
||||
struct patch_util *util = NULL;
|
||||
int in_header = 1;
|
||||
char *line, *current_filename = NULL;
|
||||
int offset, len;
|
||||
ssize_t len;
|
||||
size_t size;
|
||||
|
||||
strvec_pushl(&cp.args, "log", "--no-color", "-p", "--no-merges",
|
||||
@@ -86,11 +75,18 @@ static int read_patches(const char *range, struct string_list *list,
|
||||
|
||||
line = contents.buf;
|
||||
size = contents.len;
|
||||
for (offset = 0; size > 0; offset += len, size -= len, line += len) {
|
||||
for (; size > 0; size -= len, line += len) {
|
||||
const char *p;
|
||||
char *eol;
|
||||
|
||||
eol = memchr(line, '\n', size);
|
||||
if (eol) {
|
||||
*eol = '\0';
|
||||
len = eol + 1 - line;
|
||||
} else {
|
||||
len = size;
|
||||
}
|
||||
|
||||
len = find_end_of_line(line, size);
|
||||
line[len - 1] = '\0';
|
||||
if (skip_prefix(line, "commit ", &p)) {
|
||||
if (util) {
|
||||
string_list_append(list, buf.buf)->util = util;
|
||||
@@ -132,7 +128,8 @@ static int read_patches(const char *range, struct string_list *list,
|
||||
strbuf_addch(&buf, '\n');
|
||||
if (!util->diff_offset)
|
||||
util->diff_offset = buf.len;
|
||||
line[len - 1] = '\n';
|
||||
if (eol)
|
||||
*eol = '\n';
|
||||
orig_len = len;
|
||||
len = parse_git_diff_header(&root, &linenr, 0, line,
|
||||
len, size, &patch);
|
||||
|
||||
Reference in New Issue
Block a user