admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

environment: remove the global variable 'core_preload_index'

Browse Source 
The global variable 'core_preload_index' is used in a single function
named 'preload_index()' in "preload-index.c". Move its declaration inside
that function, removing unnecessary global state.

This change is part of an ongoing effort to eliminate global variables,
improve modularity and help libify the codebase.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com>
Signed-off-by: Ayush Chandekar <ayu.chandekar@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ayush Chandekar
2025-06-10 18:32:20 +05:30
committed by Junio C Hamano
parent 4c0e625c09
commit b1d47b464e
4 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
config.c
View File

@@ -1595,11 +1595,6 @@ static int git_default_core_config(const char *var, const char *value,
return 0; return 0;
} }
if (!strcmp(var, "core.preloadindex")) {
core_preload_index = git_config_bool(var, value);
return 0;
}
if (!strcmp(var, "core.createobject")) { if (!strcmp(var, "core.createobject")) {
if (!value) if (!value)
return config_error_nonbool(var); return config_error_nonbool(var);

3
environment.c
View File

@@ -113,9 +113,6 @@ const char *comment_line_str = "#";
char *comment_line_str_to_free; char *comment_line_str_to_free;
int auto_comment_line_char; int auto_comment_line_char;
/* Parallel index stat data preload? */
int core_preload_index = 1;
/* This is set by setup_git_directory_gently() and/or git_default_config() */ /* This is set by setup_git_directory_gently() and/or git_default_config() */
char *git_work_tree_cfg; char *git_work_tree_cfg;

1
environment.h
View File

@@ -155,7 +155,6 @@ extern int pack_compression_level;
extern unsigned long pack_size_limit_cfg; extern unsigned long pack_size_limit_cfg;
extern int max_allowed_tree_depth; extern int max_allowed_tree_depth;
extern int core_preload_index;
extern int precomposed_unicode; extern int precomposed_unicode;
extern int protect_hfs; extern int protect_hfs;
extern int protect_ntfs; extern int protect_ntfs;

4
preload-index.c
View File

@@ -19,6 +19,7 @@
#include "repository.h" #include "repository.h"
#include "symlinks.h" #include "symlinks.h"
#include "trace2.h" #include "trace2.h"
#include "config.h"
/* /*
* Mostly randomly chosen maximum thread counts: we * Mostly randomly chosen maximum thread counts: we
@@ -111,6 +112,9 @@ void preload_index(struct index_state *index,
struct thread_data data[MAX_PARALLEL]; struct thread_data data[MAX_PARALLEL];
struct progress_data pd; struct progress_data pd;
int t2_sum_lstat = 0; int t2_sum_lstat = 0;
int core_preload_index = 1;
repo_config_get_bool(the_repository, "core.preloadindex", &core_preload_index);
if (!HAVE_THREADS || !core_preload_index) if (!HAVE_THREADS || !core_preload_index)
return; return;