admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

send-pack: clean-up even when taking an early exit

Browse Source 
Previous commit has plugged one leak in the normal code path, but
there is an early exit that leaves without releasing any resources
acquired in the function.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Junio C Hamano
2025-07-01 14:17:25 -07:00
parent d1c44861f9
commit b0e9d25865
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
builtin/send-pack.c
View File

@@ -305,9 +305,10 @@ int cmd_send_pack(int argc,
flags |= MATCH_REFS_MIRROR;
/* match them up */
if (match_push_refs(local_refs, &remote_refs, &rs, flags))
return -1;
if (match_push_refs(local_refs, &remote_refs, &rs, flags)) {
ret = -1;
goto cleanup;
}
if (!is_empty_cas(&cas))
apply_push_cas(&cas, remote, remote_refs);
@@ -340,6 +341,7 @@ int cmd_send_pack(int argc,
/* stable plumbing output; do not modify or localize */
fprintf(stderr, "Everything up-to-date\n");
cleanup:
string_list_clear(&push_options, 0);
free_refs(remote_refs);
free_refs(local_refs);