admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

builtin/fetch-pack: cleanup before return error

Browse Source 
In builtin/fetch-pack.c:cmd_fetch_pack(), if finish_connect() failed,
it returns error code without cleanup which cause memory leak. Add
cleanup label before frees in the end of cmd_fetch_pack(), and add
`goto cleanup` if finish_connect() failed.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Lidong Yan
2025-06-04 03:07:54 +00:00
committed by Junio C Hamano
parent d50a5e8939
commit aedebdb6b9
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
builtin/fetch-pack.c
View File

@@ -274,8 +274,10 @@ int cmd_fetch_pack(int argc,
} }
close(fd[0]); close(fd[0]);
close(fd[1]); close(fd[1]);
if (finish_connect(conn)) if (finish_connect(conn)) {
return 1; ret = 1;
goto cleanup;
}
ret = !fetched_refs; ret = !fetched_refs;
@@ -291,6 +293,7 @@ int cmd_fetch_pack(int argc,
printf("%s %s\n", printf("%s %s\n",
oid_to_hex(&ref->old_oid), ref->name); oid_to_hex(&ref->old_oid), ref->name);
cleanup:
for (size_t i = 0; i < nr_sought; i++) for (size_t i = 0; i < nr_sought; i++)
free_one_ref(sought_to_free[i]); free_one_ref(sought_to_free[i]);
free(sought_to_free); free(sought_to_free);