admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

list-objects-filter: use BUG rather than die

Browse Source 
In some cases in this file, BUG makes more sense than die. In such
cases, a we get there from a coding error rather than a user error.

'return' has been removed following some instances of BUG since BUG does
not return.

Signed-off-by: Matthew DeVore <matvore@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Matthew DeVore
2018-10-05 14:31:25 -07:00
committed by Junio C Hamano
parent 99c9aa9579
commit 696aa73905
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
list-objects-filter.c
View File

@@ -44,8 +44,7 @@ static enum list_objects_filter_result filter_blobs_none(
switch (filter_situation) { switch (filter_situation) {
default: default:
die("unknown filter_situation"); BUG("unknown filter_situation: %d", filter_situation);
return LOFR_ZERO;
case LOFS_BEGIN_TREE: case LOFS_BEGIN_TREE:
assert(obj->type == OBJ_TREE); assert(obj->type == OBJ_TREE);
@@ -102,8 +101,7 @@ static enum list_objects_filter_result filter_blobs_limit(
switch (filter_situation) { switch (filter_situation) {
default: default:
die("unknown filter_situation"); BUG("unknown filter_situation: %d", filter_situation);
return LOFR_ZERO;
case LOFS_BEGIN_TREE: case LOFS_BEGIN_TREE:
assert(obj->type == OBJ_TREE); assert(obj->type == OBJ_TREE);
@@ -208,8 +206,7 @@ static enum list_objects_filter_result filter_sparse(
switch (filter_situation) { switch (filter_situation) {
default: default:
die("unknown filter_situation"); BUG("unknown filter_situation: %d", filter_situation);
return LOFR_ZERO;
case LOFS_BEGIN_TREE: case LOFS_BEGIN_TREE:
assert(obj->type == OBJ_TREE); assert(obj->type == OBJ_TREE);
@@ -389,7 +386,7 @@ void *list_objects_filter__init(
assert((sizeof(s_filters) / sizeof(s_filters[0])) == LOFC__COUNT); assert((sizeof(s_filters) / sizeof(s_filters[0])) == LOFC__COUNT);
if (filter_options->choice >= LOFC__COUNT) if (filter_options->choice >= LOFC__COUNT)
die("invalid list-objects filter choice: %d", BUG("invalid list-objects filter choice: %d",
filter_options->choice); filter_options->choice);
init_fn = s_filters[filter_options->choice]; init_fn = s_filters[filter_options->choice];