admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

u-string-list: move "test_split_in_place" to "u-string-list.c"

Browse Source 
We use "test-tool string-list split_in_place" to test the
"string_list_split_in_place" function. As we have introduced the unit
test, we'd better remove the logic from shell script to C program to
improve test speed and readability.

Signed-off-by: shejialuo <shejialuo@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
shejialuo
2025-06-29 12:28:23 +08:00
committed by Junio C Hamano
parent 07d90fda58
commit 62c514a9ef
3 changed files with 37 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
t/unit-tests/u-string-list.c
View File

@@ -53,3 +53,40 @@ void test_string_list__split(void)
t_string_list_split("", ':', -1, "", NULL);
t_string_list_split(":", ':', -1, "", "", NULL);
}
static void t_string_list_split_in_place(const char *data, const char *delim,
int maxsplit, ...)
{
struct string_list expected_strings = STRING_LIST_INIT_DUP;
struct string_list list = STRING_LIST_INIT_NODUP;
char *string = xstrdup(data);
va_list ap;
int len;
va_start(ap, maxsplit);
t_vcreate_string_list_dup(&expected_strings, 0, ap);
va_end(ap);
string_list_clear(&list, 0);
len = string_list_split_in_place(&list, string, delim, maxsplit);
cl_assert_equal_i(len, expected_strings.nr);
t_string_list_equal(&list, &expected_strings);
free(string);
string_list_clear(&expected_strings, 0);
string_list_clear(&list, 0);
}
void test_string_list__split_in_place(void)
{
t_string_list_split_in_place("foo:;:bar:;:baz:;:", ":;", -1,
"foo", "", "", "bar", "", "", "baz", "", "", "", NULL);
t_string_list_split_in_place("foo:;:bar:;:baz", ":;", 0,
"foo:;:bar:;:baz", NULL);
t_string_list_split_in_place("foo:;:bar:;:baz", ":;", 1,
"foo", ";:bar:;:baz", NULL);
t_string_list_split_in_place("foo:;:bar:;:baz", ":;", 2,
"foo", "", ":bar:;:baz", NULL);
t_string_list_split_in_place("foo:;:bar:;:", ":;", -1,
"foo", "", "", "bar", "", "", "", NULL);
}