admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

builtin/ls-remote: plug leaking server options

Browse Source 
The list of server options populated via `OPT_STRING_LIST()` is never
cleared, causing a memory leak. Plug it.

This leak is exposed by t5702, but plugging it alone does not make the
whole test suite pass.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2024-11-05 07:16:43 +01:00
committed by Junio C Hamano
parent 34b6ce9b30
commit 5f5dd8e297
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
builtin/ls-remote.c
View File

@@ -166,6 +166,7 @@ int cmd_ls_remote(int argc,
status = 0; /* we found something */ status = 0; /* we found something */
} }
string_list_clear(&server_options, 0);
ref_sorting_release(sorting); ref_sorting_release(sorting);
ref_array_clear(&ref_array); ref_array_clear(&ref_array);
if (transport_disconnect(transport)) if (transport_disconnect(transport))