admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

submodule: fix leaking submodule entry list

Browse Source 
The submodule entry list returned by `submodules_of_tree()` is never
completely free'd by its only caller. Introduce a new function that
free's the list for us and call it.

While at it, also fix the leaking `branch_point` string.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Patrick Steinhardt
2024-09-30 11:13:27 +02:00
committed by Junio C Hamano
parent 666643fa89
commit 5cca114973
4 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
submodule-config.c
View File

@@ -901,8 +901,9 @@ static void traverse_tree_submodules(struct repository *r,
struct submodule_tree_entry *st_entry;
struct name_entry name_entry;
char *tree_path = NULL;
char *tree_buf;
fill_tree_descriptor(r, &tree, treeish_name);
tree_buf = fill_tree_descriptor(r, &tree, treeish_name);
while (tree_entry(&tree, &name_entry)) {
if (prefix)
tree_path =
@@ -930,6 +931,8 @@ static void traverse_tree_submodules(struct repository *r,
&name_entry.oid, out);
free(tree_path);
}
free(tree_buf);
}
void submodules_of_tree(struct repository *r,
@@ -943,6 +946,16 @@ void submodules_of_tree(struct repository *r,
traverse_tree_submodules(r, treeish_name, NULL, treeish_name, out);
}
void submodule_entry_list_release(struct submodule_entry_list *list)
{
for (size_t i = 0; i < list->entry_nr; i++) {
free(list->entries[i].name_entry);
repo_clear(list->entries[i].repo);
free(list->entries[i].repo);
}
free(list->entries);
}
void submodule_free(struct repository *r)
{
if (r->submodule_cache)