admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

*.[ch]: remove extern from function declarations using spatch

Browse Source 
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.

This was the Coccinelle patch used:

	@@
	type T;
	identifier f;
	@@
	- extern
	  T f(...);

and it was run with:

	$ git ls-files \*.{c,h} |
		grep -v ^compat/ |
		xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place

Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Denton Liu
2019-04-29 04:28:14 -04:00
committed by Junio C Hamano
parent ffac537e6c
commit 554544276a
70 changed files with 885 additions and 885 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
oidmap.h
View File

@@ -33,7 +33,7 @@ struct oidmap {
* parameter may be used to preallocate a sufficiently large table and thus
* prevent expensive resizing. If 0, the table is dynamically resized.
*/
extern void oidmap_init(struct oidmap *map, size_t initial_size);
void oidmap_init(struct oidmap *map, size_t initial_size);
/*
* Frees an oidmap structure and allocated memory.
@@ -41,12 +41,12 @@ extern void oidmap_init(struct oidmap *map, size_t initial_size);
* If `free_entries` is true, each oidmap_entry in the map is freed as well
* using stdlibs free().
*/
extern void oidmap_free(struct oidmap *map, int free_entries);
void oidmap_free(struct oidmap *map, int free_entries);
/*
* Returns the oidmap entry for the specified oid, or NULL if not found.
*/
extern void *oidmap_get(const struct oidmap *map,
void *oidmap_get(const struct oidmap *map,
const struct object_id *key);
/*
@@ -57,14 +57,14 @@ extern void *oidmap_get(const struct oidmap *map,
*
* Returns the replaced entry, or NULL if not found (i.e. the entry was added).
*/
extern void *oidmap_put(struct oidmap *map, void *entry);
void *oidmap_put(struct oidmap *map, void *entry);
/*
* Removes an oidmap entry matching the specified oid.
*
* Returns the removed entry, or NULL if not found.
*/
extern void *oidmap_remove(struct oidmap *map, const struct object_id *key);
void *oidmap_remove(struct oidmap *map, const struct object_id *key);
struct oidmap_iter {