admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pack-bitmap: drop unused parameters from select_pseudo_merges()

Browse Source 
We take the array of indexed_commits (and its length), but there's no
need. The selection is based on ref reachability, not the linearized set
of commits we're packing.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King
2024-08-17 03:29:37 -04:00
committed by Junio C Hamano
parent ecc6fa9ae9
commit 4756494504
3 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pack-bitmap-write.c
View File

@@ -737,7 +737,7 @@ void bitmap_writer_select_commits(struct bitmap_writer *writer,
stop_progress(&writer->progress); stop_progress(&writer->progress);
select_pseudo_merges(writer, indexed_commits, indexed_commits_nr); select_pseudo_merges(writer);
} }

3
pseudo-merge.c
View File

@@ -425,8 +425,7 @@ static void sort_pseudo_merge_matches(struct pseudo_merge_matches *matches)
QSORT(matches->unstable, matches->unstable_nr, commit_date_cmp); QSORT(matches->unstable, matches->unstable_nr, commit_date_cmp);
} }
void select_pseudo_merges(struct bitmap_writer *writer, void select_pseudo_merges(struct bitmap_writer *writer)
struct commit **commits, size_t commits_nr)
{ {
struct progress *progress = NULL; struct progress *progress = NULL;
uint32_t i; uint32_t i;

3
pseudo-merge.h
View File

@@ -95,8 +95,7 @@ struct pseudo_merge_commit_idx {
* *
* Optionally shows a progress meter. * Optionally shows a progress meter.
*/ */
void select_pseudo_merges(struct bitmap_writer *writer, void select_pseudo_merges(struct bitmap_writer *writer);
struct commit **commits, size_t commits_nr);
/* /*
* Represents a serialized view of a file containing pseudo-merge(s) * Represents a serialized view of a file containing pseudo-merge(s)