admin/git
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

t/unit-tests: convert reftable stack test to use clar

Browse Source 
Adapt reftable stack test file to use clar by using clar assertions
where necessary.

This marks the end of all unit tests migrated away from the
`unit-tests/t-*.c` pattern, there are no longer any files matching that
glob. Remove the sanity check for `t-*.c` files to prevent Meson
configuration errors during CI and local builds.

Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Seyi Kuforiji
2025-07-24 15:28:36 +01:00
committed by Junio C Hamano
parent 2596bef584
commit 1cfd187fc1
3 changed files with 332 additions and 454 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Makefile
View File

@@ -1369,6 +1369,7 @@ CLAR_TEST_SUITES += u-reftable-block
CLAR_TEST_SUITES += u-reftable-merged CLAR_TEST_SUITES += u-reftable-merged
CLAR_TEST_SUITES += u-reftable-pq CLAR_TEST_SUITES += u-reftable-pq
CLAR_TEST_SUITES += u-reftable-readwrite CLAR_TEST_SUITES += u-reftable-readwrite
CLAR_TEST_SUITES += u-reftable-stack
CLAR_TEST_SUITES += u-reftable-table CLAR_TEST_SUITES += u-reftable-table
CLAR_TEST_SUITES += u-reftable-tree CLAR_TEST_SUITES += u-reftable-tree
CLAR_TEST_SUITES += u-strbuf CLAR_TEST_SUITES += u-strbuf
@@ -1383,7 +1384,6 @@ CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/unit-test.o
CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-oid.o CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-oid.o
CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable-clar.o CLAR_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable-clar.o
UNIT_TEST_PROGRAMS += t-reftable-stack
UNIT_TEST_PROGS = $(patsubst %,$(UNIT_TEST_BIN)/%$X,$(UNIT_TEST_PROGRAMS)) UNIT_TEST_PROGS = $(patsubst %,$(UNIT_TEST_BIN)/%$X,$(UNIT_TEST_PROGRAMS))
UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/test-lib.o
UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o UNIT_TEST_OBJS += $(UNIT_TEST_DIR)/lib-reftable.o

4
t/meson.build
View File

@@ -14,6 +14,7 @@ clar_test_suites = [
'unit-tests/u-reftable-pq.c', 'unit-tests/u-reftable-pq.c',
'unit-tests/u-reftable-readwrite.c', 'unit-tests/u-reftable-readwrite.c',
'unit-tests/u-reftable-record.c', 'unit-tests/u-reftable-record.c',
'unit-tests/u-reftable-stack.c',
'unit-tests/u-reftable-table.c', 'unit-tests/u-reftable-table.c',
'unit-tests/u-reftable-tree.c', 'unit-tests/u-reftable-tree.c',
'unit-tests/u-strbuf.c', 'unit-tests/u-strbuf.c',
@@ -62,7 +63,6 @@ clar_unit_tests = executable('unit-tests',
test('unit-tests', clar_unit_tests) test('unit-tests', clar_unit_tests)
unit_test_programs = [ unit_test_programs = [
'unit-tests/t-reftable-stack.c',
] ]
foreach unit_test_program : unit_test_programs foreach unit_test_program : unit_test_programs
@@ -1164,8 +1164,6 @@ benchmarks = [
# sufficient to catch missing test suites in our CI though. # sufficient to catch missing test suites in our CI though.
foreach glob, tests : { foreach glob, tests : {
't[0-9][0-9][0-9][0-9]-*.sh': integration_tests, 't[0-9][0-9][0-9][0-9]-*.sh': integration_tests,
'perf/p[0-9][0-9][0-9][0-9]-*.sh': benchmarks,
'unit-tests/t-*.c': unit_test_programs,
'unit-tests/u-*.c': clar_test_suites, 'unit-tests/u-*.c': clar_test_suites,
} }
actual_tests = run_command(shell, '-c', 'ls ' + glob, actual_tests = run_command(shell, '-c', 'ls ' + glob,

780
t/unit-tests/t-reftable-stack.c → t/unit-tests/u-reftable-stack.c
View File

File diff suppressed because it is too large Load Diff