t/t5305-include-tag.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
committed by
Junio C Hamano
parent
213ea1161c
commit
0469cb96e3
@@ -3,20 +3,20 @@
|
|||||||
test_description='git pack-object --include-tag'
|
test_description='git pack-object --include-tag'
|
||||||
. ./test-lib.sh
|
. ./test-lib.sh
|
||||||
|
|
||||||
TRASH=`pwd`
|
TRASH=$(pwd)
|
||||||
|
|
||||||
test_expect_success setup '
|
test_expect_success setup '
|
||||||
echo c >d &&
|
echo c >d &&
|
||||||
git update-index --add d &&
|
git update-index --add d &&
|
||||||
tree=`git write-tree` &&
|
tree=$(git write-tree) &&
|
||||||
commit=`git commit-tree $tree </dev/null` &&
|
commit=$(git commit-tree $tree </dev/null) &&
|
||||||
echo "object $commit" >sig &&
|
echo "object $commit" >sig &&
|
||||||
echo "type commit" >>sig &&
|
echo "type commit" >>sig &&
|
||||||
echo "tag mytag" >>sig &&
|
echo "tag mytag" >>sig &&
|
||||||
echo "tagger $(git var GIT_COMMITTER_IDENT)" >>sig &&
|
echo "tagger $(git var GIT_COMMITTER_IDENT)" >>sig &&
|
||||||
echo >>sig &&
|
echo >>sig &&
|
||||||
echo "our test tag" >>sig &&
|
echo "our test tag" >>sig &&
|
||||||
tag=`git mktag <sig` &&
|
tag=$(git mktag <sig) &&
|
||||||
rm d sig &&
|
rm d sig &&
|
||||||
git update-ref refs/tags/mytag $tag && {
|
git update-ref refs/tags/mytag $tag && {
|
||||||
echo $tree &&
|
echo $tree &&
|
||||||
|
|||||||
Reference in New Issue
Block a user